GeezerVison

🦋 Changeset detected

Latest commit: f5dd1bc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

Learnt from: NERLOE
URL: https://github.com/triggerdotdev/trigger.dev/pull/4980

Timestamp: 2026-09-25T11:45:20.033Z
Learning: In `packages/core/src/v3/zodIpc.ts`, ACK packets without `message` were accepted under zod 3 and zod 4.0–4.3 because the `z.any()` key was optional at parse time. PR `#4980` restores that behavior for zod 4.4+. Validating ACKs against their expected callback schemas would change `sendWithAck` semantics and is separate hardening work.

Walkthrough

The ACK packet schema now permits the message field to be absent. Tests use a forked child process to check void and payload acknowledgments. A patch changeset describes the task completion and cancellation delays reported for projects using Zod 4.4 or newer.

Priority: ⬆️ High

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 42f25

The change addresses delayed completion and cancellation acknowledgments. No concrete merge-blocking risk is identified; normal checks remain appropriate.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 41287

The change restores acknowledgments from child processes when callbacks return no value. No new externally reachable entrypoint or introduced security bypass was established, but the shared completion protocol warrants review.

Retained concerns
No architecture-level concerns identified.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

@coderabbitai On the retained reliability concern (an ACK without message can now resolve a non-void request): this is the behaviour zodIpc had under zod 3 and zod 4.0–4.3, where a z.any() key was already optional at parse time. This PR restores it for zod 4.4+ rather than introducing it. Validating each ack against its expected callback schema would be a reasonable hardening, but it changes sendWithAck semantics beyond this bug fix, so I'd keep it out of scope here.

Changeset wording fixed in d098714 as well.

For maintainers: the failing webapp unit/E2E checks are the fork-secrets issue (DockerHub login skipped because secrets are not available, then quay.io/minio/minio pull is unauthorized). code-quality, typecheck and all package unit-test shards (which run the new test) pass.

#!/bin/bash
set -euo pipefail
fd -a '^(zodIpc\.ts|zodIpc\.test\.ts|void-ipc-acks\.md)$'
ast-grep outline packages/core/src/v3/zodIpc.ts --items all
ast-grep outline packages/core/test/zodIpc.test.ts --items all
sed -n '1,280p' packages/core/src/v3/zodIpc.ts
sed -n '1,180p' packages/core/test/zodIpc.test.ts
cat .changeset/void-ipc-acks.md
git show HEAD^:packages/core/src/v3/zodIpc.ts | sed -n '1,110p' || true

@NERLOE, thanks for the clarification. I agree that per-callback ACK validation is a separate hardening change, not a requirement for this fix. I withdraw the retained reliability concern as a finding on this PR.

I also see the corrected changeset wording. Thanks for the context on the webapp checks; I have not independently verified their failure logs. Would you like a follow-up issue for ACK callback validation?

Learnt from: NERLOE
URL: https://github.com/triggerdotdev/trigger.dev/pull/4980

Timestamp: 2026-09-25T11:45:19.903Z
Learning: In `packages/core/src/v3/zodIpc.ts`, ACK packets without `message` were accepted under zod 3 and zod 4.0–4.3 because the `z.any()` key was optional at parse time. PR `#4980` restores that behavior for zod 4.4+. Validating ACKs against their expected callback schemas would change `sendWithAck` semantics and is separate hardening work.

You are interacting with an AI system.