GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — 🤖 User test baselines have changed for omit-on-indexable-type by typescript-bot · Pull Request #142 · typescript-bot/TypeScript

Conversation

typescript-bot commented Jan 27, 2021

Copy link

Copy Markdown

Owner

This test run was triggerd by a request on microsoft#42524
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @weswigham

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

typescript-bot added 2 commits

January 27, 2021 22:16


          Update user baselines +cc @sandersn

4c6557e


          Update user baselines

7b8d79d

typescript-bot mentioned this pull request

Jan 27, 2021

Use homomorphic templated type for Omit microsoft/TypeScript#42524

Closed

weswigham reviewed

Jan 27, 2021

View reviewed changes

Comment thread

tests/baselines/reference/user/webpack.log

		@@ -0,0 +1,12 @@
		Exit Code: 2
		Standard output:
		lib/util/cleverMerge.js(538,3): error TS2322: Type 'T' is not assignable to type 'Omit<T, P>'.

weswigham Jan 27, 2021

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh yeah, might need full assignability rules for .nameType- having mapped types before we can ship this change, rather than just comparability rules.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

typescript-bot force-pushed the user-baseline-updates branch 26 times, most recently from 2d08609 to 60b1907 Compare

February 3, 2021 20:04

typescript-bot force-pushed the user-baseline-updates branch 29 times, most recently from 77b2149 to 6a4fdd0 Compare

February 12, 2021 19:27

typescript-bot force-pushed the user-baseline-updates branch from 6a4fdd0 to 97ceb71 Compare

February 12, 2021 23:23

Reviewers

weswigham

weswigham left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.