Description

kikonen

opened on Jul 10, 2016

Issue body actions

Noticed when tried to use typescript-rails, actual issue is apparently within this gem.

typescript-ruby/typescript-rails#42

Based into documentation (https://www.typescriptlang.org/docs/handbook/compiler-options.html), "--out" options is deprecated and should use "--outFile". Did quick hack to test that, and didn't notice any change in behavior (output_js still became empty, and "/tmp" appears to contain generated temp files instead).

Activity

1. kikonen commented on Jul 10, 2016

   

   kikonen

   on Jul 10, 2016

   Author

   More actions

   Seems to work with following patch

   module TypeScript
     module Node
   ...
         def compile_file(source_file, *tsc_options)
   ...
   #          output_file = File.join(output_dir, 'out.js')
   #          stdout, stderr, exit_status = tsc(*tsc_options, '--out', output_file, source_file)
             output_file = source_file.sub(/\.ts\z/, '.js')
             stdout, stderr, exit_status = tsc(*tsc_options, source_file)
   ...

   Issue occurred when using command line options

   [
     '--target', 'ES5',
     '--noImplicitAny',
     '--module', 'system',
     ]
2. arnvald

   added a commit that references this issue on Aug 13, 2017

   Fixed generating output

   6dec35d

Issue actions