GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — execution reverted by new coin (even after liquidity added) · Issue #350 · uniswap-python/uniswap-python

execution reverted by new coin (even after liquidity added) #350

New issue
Copy link
New issue
Copy link
Open
Open
execution reverted by new coin (even after liquidity added)#350
Copy link
Labels
bugSomething isn't workingSomething isn't working

Description

@drone4
drone4
opened on Oct 13, 2023
Issue body actions

Hi,

By relatively new coins execution always reverted, if no yet liquidity, then no transaction, if liquidity exists it transact, deduct fee but fail.
Even with 0.9 slippage and 1.5current fee, why?
https://etherscan.io/tx/0x1ba2897733c8aacecad59593dd66ed333156645cb1c5d604a45524c9de34f91b
version = 2
provider = "https://mainnet.infura.io/v3/myinfura"
eth = "0x0000000000000000000000000000000000000000"
uniswap = Uniswap(address=address, private_key=private_key, version=version, provider=provider)
uniswap.make_trade(eth, coin, 1
10**16, slippage=0.9, fee=current_gas_price*1.5)
Thanks

Activity

  1. drone4
    added
    bugSomething isn't workingSomething isn't working
    on Oct 13, 2023
  2. liquid-8 commented on Oct 28, 2023

    @liquid-8
    liquid-8
    on Oct 28, 2023
    Member
    More actions

    The fee param doesn't (and shouldn't) work for V2. By the way, you misinterpret its meaning. However, this error doesn't occur for other tokens. This particular token was likely drained ~two weeks ago, so I can't reproduce it at the moment.

  3. drone4 commented on Oct 28, 2023

    @drone4
    drone4
    on Oct 28, 2023 via email
    Author
    More actions
    Thanks 2023. október 28., szombat dátummal Yohan K ***@***.***> ezt írta:
    …
    The fee param doesn't (and shouldn't) work for V2. By the way, you misinterpret its meaning. However, this error doesn't occur for other tokens. This particular token was likely drained ~two weeks ago, so I can't reproduce it at the moment. — Reply to this email directly, view it on GitHub <#350 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGDDPG3OWN5QUZ762SJOSB3YBUNLZAVCNFSM6AAAAAA56XDKIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHA2DCMZTGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.