GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support swapping directly with WETH by kayibal · Pull Request #124 · uniswap-python/uniswap-python

Conversation

@kayibal

@kayibal kayibal commented Jun 25, 2021

Copy link
Copy Markdown

Hi all,

I noticed that swapping with WETH currently results in an error. This is an attempt to fix it. Unfortunately I couldn't include test cases for make_trade, as these would require conversion from ETH to WETH which is not supported either.

TODO:

  • One test seems to be failing, but I couldn't find the issue. Would appreciate support here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kayibal
Support swapping directly with WETH
8a99c5d
@kayibal
kayibal marked this pull request as draft June 25, 2021 08:37
@ErikBjare
ErikBjare force-pushed the master branch from f15ccc6 to 2b04dd3 Compare October 24, 2022 08:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kayibal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.