GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: make_trade add optional route param by starascendin · Pull Request #239 · uniswap-python/uniswap-python

Conversation

@starascendin

@starascendin starascendin commented Mar 7, 2022

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
starascendin added 4 commits March 5, 2022 11:34
@starascendin
BL: adding route support
16fffdb
@starascendin
BL: 0.5.5.5.2
da2d791
@starascendin
code cleanup
0652a2f
@starascendin
clean up code
e77d98b
ErikBjare
ErikBjare reviewed Jul 13, 2022
View reviewed changes
Comment thread uniswap/uniswap.py
fee: int = None,
slippage: float = None,
fee_on_transfer: bool = False,
route: Optional[List[AddressLike]] = None,

@ErikBjare ErikBjare Jul 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might lead to unexpected behavior if route is specified but not respected (such as in the eth_to_token and token_to_eth cases).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ErikBjare
ErikBjare reviewed Jul 13, 2022
View reviewed changes
Comment thread uniswap/uniswap.py
fee: int,
slippage: float,
fee_on_transfer: bool = False,
route: Optional[List[AddressLike]] = None,

@ErikBjare ErikBjare Jul 13, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as above, needs to be respected in all cases, or raise an exception if it can't.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ErikBjare
ErikBjare force-pushed the master branch from f15ccc6 to 2b04dd3 Compare October 24, 2022 08:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikBjare ErikBjare ErikBjare left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@starascendin @ErikBjare
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.