GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: price impact excludes fees by Voyz · Pull Request #325 · uniswap-python/uniswap-python

Conversation

@Voyz

@Voyz Voyz commented Mar 18, 2023

Copy link
Copy Markdown
Contributor
  • added util functions for fee calculations
  • price impact calculation now excludes fees

Based on discussion in: #310

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Voyz added 2 commits March 18, 2023 19:22
@Voyz
feat: added util functions for fee calculations
a1b1083
@Voyz
feat: price impact calculation now excludes fees
d88362d
@Voyz Voyz mentioned this pull request Mar 18, 2023
Shouldn't fees be excluded when estimating the price impact? #310
Open
@Voyz

Voyz commented Jun 22, 2023

Copy link
Copy Markdown
Contributor Author

@ErikBjare just wanted to bring this PR to your attention again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ErikBjare
ErikBjare approved these changes Jun 22, 2023
View reviewed changes

@ErikBjare ErikBjare left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just remove the unused function and format with black.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread uniswap/util.py Outdated
def fee_to_fraction(fee:int):
return fee / 1000000

def fraction_to_fee(fraction:float):

@ErikBjare ErikBjare Jun 22, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Voyz added 2 commits July 21, 2023 10:06
@Voyz
removed unused 'fraction_to_fee' and reformatted with black
99cef12
@Voyz
Merge branch 'master' into master
644e71f
@Voyz

Voyz commented Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

Hey @ErikBjare removed the function and formatted with black 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Voyz

Voyz commented Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

@ErikBjare just wanted to bring this PR to your attention again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare

ErikBjare commented Sep 8, 2023

Copy link
Copy Markdown
Member

Very nice, thanks for the ping!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare
ErikBjare merged commit 9a1318f into uniswap-python:master Sep 8, 2023
@ErikBjare

ErikBjare commented Sep 8, 2023

Copy link
Copy Markdown
Member

And thanks for contributing! ❤️
Voyz reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Voyz

Voyz commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

Glad to have helped! 🙌
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikBjare ErikBjare ErikBjare approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Voyz @ErikBjare
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.