GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Uniswap v4 support by ErikBjare · Pull Request #340 · uniswap-python/uniswap-python

Conversation

@ErikBjare

@ErikBjare ErikBjare commented Jul 4, 2023

Copy link
Copy Markdown
Member

Just a PR with all the changes in the dev/v4 branch.

Closes #337

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
liquid-8 and others added 6 commits June 27, 2023 22:47
@liquid-8
v4 support pre-alpha
b952063
@liquid-8
v4 support pre-alpha
38e1d02
@liquid-8
v4 support pre-alpha
f64bdee
@liquid-8
v4 support pre-alpha
e59ec71
@liquid-8
v4 support pre-alpha
8115417
@liquid-8
Merge pull request #339 from liquid-8/dev
054c25c 
v4 support pre-alpha
@ErikBjare ErikBjare mentioned this pull request Jul 4, 2023
Uniswap v4 support #337
Closed
liquid-8 and others added 5 commits August 21, 2023 17:29
@liquid-8
futhermore
24c3671
@liquid-8
Pool manager ABI added;
c91c767 
Poolid function fix;
Splitting methods to contract's calls wraps and market functions.
@liquid-8
Merge pull request #349 from liquid-8/dev
7f7cbe9 
 Pool manager ABI added;  Poolid function fix; Splitting methods to contract's calls wraps and market functions.
@liquid-8
UniswapV4 alpha
2f9e012
@liquid-8
Merge pull request #365 from liquid-8/dev
dbe104f 
UniswapV4 alpha
@ErikBjare
ErikBjare marked this pull request as ready for review January 8, 2024 08:47
liquid-8 and others added 11 commits January 8, 2024 11:14
@liquid-8
Update __init__.py
2109070
@ErikBjare
Merge branch 'master' into dev/v4
3087004
@liquid-8
fix p.1
442771d
@liquid-8
and more
5a3e35b
@liquid-8
Merge pull request #366 from liquid-8/dev
af83aa3 
fix p1
@liquid-8
and more
a908abd
@liquid-8
Merge pull request #367 from liquid-8/dev
f06e3d1 
and more
@liquid-8
and more
fd3f932
@liquid-8
Merge pull request #368 from liquid-8/dev
8188da6 
and more
@liquid-8
and more
7309f15
@liquid-8
Merge pull request #369 from liquid-8/dev
cd1b348 
and more!
@codecov

codecov Bot commented Jan 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.16425% with 128 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.26%. Comparing base (4f15d2e) to head (1fee875).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
uniswap/uniswap4.py 27.10% 121 Missing ⚠️
uniswap/util.py 20.00% 4 Missing ⚠️
uniswap/types.py 90.32% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #340       +/-   ##
===========================================
- Coverage   71.22%   52.26%   -18.97%     
===========================================
  Files          11       12        +1     
  Lines        1074     1280      +206     
===========================================
- Hits          765      669       -96     
- Misses        309      611      +302

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
liquid-8 and others added 5 commits January 9, 2024 18:41
@liquid-8
fix p.2
c5fd61c
@liquid-8
Merge pull request #370 from liquid-8/dev
8fc43e7 
fix p.2
@liquid-8
fix p2.1
de55f29
@liquid-8
Merge pull request #371 from liquid-8/dev
b4c8e88 
 fix p2.1
@liquid-8
fix p2.2
b055385
liquid-8 and others added 11 commits June 5, 2024 23:26
@liquid-8
Merge pull request #388 from uniswap-python/master
ac9545c 
1
@liquid-8
price fetching refactored; custom gas pricing; misc
2bc594c
@liquid-8
Merge pull request #389 from liquid-8/dev
c1f237a 
price fetching refactored; custom gas pricing; misc
@liquid-8
typing fixes
14130d1
@liquid-8
Merge pull request #390 from liquid-8/dev
0ebdb89 
typing fixes
@liquid-8
typing fix 2
88e9275
@liquid-8
Merge pull request #391 from liquid-8/dev
56be7db 
typing fix 2
@liquid-8
typing fixes
ab23b04
@liquid-8
Merge pull request #392 from liquid-8/dev
3deff6f 
typing fixes
@liquid-8
123
1a81999
@liquid-8
Merge pull request #393 from liquid-8/dev
f277370 
some more fixes
@liquid-8

liquid-8 commented Jun 6, 2024

Copy link
Copy Markdown
Member

@ErikBjare ^^
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
liquid-8 and others added 12 commits June 8, 2024 02:53
@liquid-8
ABIs update
9444386
@liquid-8
Merge pull request #394 from liquid-8/dev
b7bb565 
ABIs update
@liquid-8
final fixes and clean-ups
7383ee0
@liquid-8
Merge pull request #396 from liquid-8/dev
f28ec7e 
final fixes and clean-ups
@liquid-8
1
890dab5
@liquid-8
Merge pull request #397 from liquid-8/dev
740644b 
typing fix
@liquid-8
2
a252678
@liquid-8
Merge pull request #398 from liquid-8/dev
b3a53c5 
2
@liquid-8
more stupidity fix
70a627b
@liquid-8
Merge pull request #399 from liquid-8/dev
3dbb914 
more stupidity fix
@liquid-8
1
371454b
@liquid-8
Merge pull request #400 from liquid-8/dev
f7297f9 
1
ErikBjare
ErikBjare commented Jun 10, 2024
View reviewed changes
Comment thread uniswap/constants.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread uniswap/uniswap4.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
liquid-8 and others added 4 commits June 10, 2024 22:13
@liquid-8 @ErikBjare
Update uniswap/constants.py
f442f4b 
Co-authored-by: Erik Bjäreholt <[email protected]>
@liquid-8
Update uniswap4.py: get_token() removed
812b5d6
@liquid-8
Update uniswap4.py: removed wallet-related functions
30a4efe
@liquid-8
Update uniswap4.py: removed to_checksum_address in get_pool_id()
1fee875
@ErikBjare ErikBjare closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liquid-8 liquid-8 liquid-8 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uniswap v4 support

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ErikBjare @liquid-8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.