GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update uniswap.py by RedstonedLife · Pull Request #408 · uniswap-python/uniswap-python

Conversation

@RedstonedLife

@RedstonedLife RedstonedLife commented Oct 23, 2024

Copy link
Copy Markdown

This change fixes a ValueError exception caused by web3.py, when using self.w3.net.version it can return a hexadecimal number which needs to be handled differently than a regular integer.

Basically,

self.netid = int(self.w3.net.version)

will throw a ValueError because the number of the version is returned in hexadecimal format 0x1, which needs to be translated from base-16 instead of base-10 which is now properly handled by a try and catch clause.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RedstonedLife
Update uniswap.py
3111893 
This change fixes a ValueError exception caused by web3.py, when using self.w3.net.version it can return a hexadecimal number which needs to be handled differently than a regular integer.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@RedstonedLife
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.