GeezerVison

Greptile Summary

The PR raises the minimum supported Python version and modernizes development, documentation, and dependency tooling.

• Updates documentation, test, and type-check workflows to Python 3.12.
• Replaces Black and Flake8 Make targets with Poetry-managed Ruff commands.
• Refreshes runtime and development dependency constraints and regenerates the lock file.
• Moves typing helpers to the standard library and updates Sphinx configuration.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

_{Reviews (3): Last reviewed commit: "fix(deps): add ruff as explicit dev depe..." | Re-trigger Greptile}

CI was failing because several transitive Cython packages (cytoolz, frozenlist, yarl, multidict) declared python-versions >= 3.6 in their metadata but shipped no pre-built cp312 wheels. Under Python 3.12 poetry resolved to old versions that then failed to compile from source.

Fixed by adding explicit minimum floors in pyproject.toml so poetry resolves to cp312-wheel-shipping versions:

• cytoolz >= 0.12.3 → locked to 1.1.0
• frozenlist >= 1.5.0 → locked to 1.8.0
• multidict >= 6.0.5 → locked to 6.7.1
• yarl >= 1.10.0 → locked to 1.24.5 (pulls in propcache 0.5.2 as a new transitive dep)

Lock file regenerated and pushed. CI re-running now.

All Greptile P1 findings now addressed:

Docs workflow Python version — fixed in ed6a6bd: .github/workflows/docs.yml uses Python 3.12 (Sphinx 9 requires it).

Makefile lint/format targets — fixed in cf5d3fe: lint and format targets now invoke ruff instead of the removed black/flake8.

Transitive Cython packages without cp312 wheels — fixed across two commits:

• 4919e01: added floors for cytoolz ≥0.12.3, frozenlist ≥1.5.0, multidict ≥6.0.5, yarl ≥1.10.0
• c52ab87: added floor for aiohttp ≥3.9.0 (web3's transitive dep that was locking to 3.8.4, which has no cp312 wheels and fails to compile on Python 3.12 due to the removed PyLongObject.ob_digit field)

Lock file re-generated; CI running now.

CI was still failing after the aiohttp fix, from two separate causes:

1. Test + typecheck jobs: eth-keyfile (pulled in via web3 → eth-account) still imports pkg_resources, which setuptools dropped starting in 82.0.0 (present through 81.0.0). eth-account>=0.12 fixes this upstream, but it requires hexbytes>=1.2.0, which conflicts with web3 6.x's hexbytes<0.4.0 pin — bridging that needs the (deliberately deferred) web3 7.x migration. Pinned setuptools<82 as a stopgap; also floored typing-extensions>=4.12.0 since 4.5.0 crashes under Python 3.12.13's stricter TypeVar base-class check.

2. Docs build: sphinx-book-theme was resolving to 0.0.11 (a 2020-era release, incompatible with Sphinx 9's theme API — missing get_edit_url). Floored it to ^1.1, which also pulls a compatible pydata-sphinx-theme (0.20.0). That surfaced one more issue: Sphinx 9 hard-fails on the old implicit-%s extlinks caption format ("issue #" → "issue #%s").

Verified locally in an isolated poetry venv: full install, make html docs build, pytest collection (250 tests), and mypy --pretty all pass.

@greptileai review

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.23%. Comparing base (2ef33e2) to head (c9337eb).

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   73.19%   73.23%   +0.04%     
==========================================
  Files          12       12              
  Lines        2309     2313       +4     
==========================================
+ Hits         1690     1694       +4     
  Misses        619      619              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Greptile round 2 correctly flagged that ruff was missing from [tool.poetry.dev-dependencies] — the Makefile calls poetry run ruff check and poetry run ruff format, but a fresh poetry install would not pull in ruff, so those targets would fail immediately.

Fixed in c9337eb: added ruff = ">=0.9" to [tool.poetry.dev-dependencies] and regenerated the lock file. CI is running on that head now.

@greptileai review

Ready to merge — Greptile round 3 returned 5/5 ("The PR appears safe to merge") on head c9337eb. All 6 CI jobs pass (build, test v1–v4 mainnet, typecheck).

What was fixed across the review rounds:

No blocking findings remain. Deferred item still in scope: web3 7.x upgrade (async-first rewrite, deliberately left for a separate PR per the original description).