GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — D2 by liquid-8 · Pull Request #496 · uniswap-python/uniswap-python

Conversation

@liquid-8

@liquid-8 liquid-8 commented Nov 12, 2026

Copy link
Copy Markdown
Member

Add multihop routes support in v2/v3 for native ETH in Uniswap/AsyncUniswap

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@liquid-8
Add native ETH routes in v2/v3 support
57688df
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The changes appear safe to merge; all previous findings are addressed.

Summary

Adds custom multihop routes for native ETH quotes and trades in Uniswap and AsyncUniswap.

  • Native-ETH quotes and swaps can follow caller-selected multi-hop routes.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Token-to-ETH trade] --> B[Quote supplied route]
    B --> C[Apply spending limit]
    C --> D[Swap with ETH_ADDRESS recipient]
    D --> E[Router holds WETH]
    E --> F[unwrapWETH9 sends ETH to recipient]
Loading

Reviews (3) · Last reviewed commit: "exact-output v3 trades unwrap fix" · Reviewed by Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot]
greptile-apps Bot reviewed Nov 12, 2026
View reviewed changes
Comment thread uniswap/uniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread uniswap/uniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread uniswap/uniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread uniswap/asyncuniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread uniswap/asyncuniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.19718% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.55%. Comparing base (5fa5c57) to head (23fc5c9).

Files with missing lines Patch % Lines
uniswap/asyncuniswap.py 66.19% 24 Missing ⚠️
uniswap/uniswap.py 66.19% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   71.03%   70.55%   -0.49%     
==========================================
  Files          14       14              
  Lines        4302     4394      +92     
==========================================
+ Hits         3056     3100      +44     
- Misses       1246     1294      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@liquid-8
review fixes
87de1bb
@liquid-8

liquid-8 commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

@greptileai review

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@liquid-8
exact-output v3 trades unwrap fix
23fc5c9
@liquid-8

liquid-8 commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@greptileai review

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@liquid-8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.