GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: initial support for custom deployments and routes by ErikBjare · Pull Request #58 · uniswap-python/uniswap-python

Conversation

@ErikBjare

@ErikBjare ErikBjare commented Jan 11, 2021

Copy link
Copy Markdown
Member

Very WIP.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ErikBjare ErikBjare mentioned this pull request Jan 20, 2021
SushiSwap support #62
Closed
@ErikBjare

ErikBjare commented Jan 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

As I mentioned in #62, it might be better to add the ability to override the router and factory contract addresses from the constructor parameters (since it generalizes support across all Uniswap clones).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare ErikBjare changed the title feat: initial support for Honeyswap (on xDai) feat: initial support for Honeyswap (on xDai) and specific routes Jan 20, 2021
@ErikBjare ErikBjare mentioned this pull request Feb 22, 2021
Quickswap support #67
Closed
@ErikBjare ErikBjare mentioned this pull request Apr 27, 2021
Pancake and BSC fork #90
Closed
ErikBjare added 2 commits May 4, 2021 13:40
@ErikBjare
feat: initial support for Honeyswap (on xDai)
a94e680
@ErikBjare
fix: removed unneeded workaround
9be2fbf
@ErikBjare
ErikBjare force-pushed the dev/honeyswap branch from f3aec1a to 9be2fbf Compare May 4, 2021 11:41
ErikBjare added 2 commits May 4, 2021 14:03
@ErikBjare
test: fixed test that tried to trade an asset we didn't have
87b24ca
@ErikBjare
feat: parametrized factory and router contract addresses to support c…
f18b05b 
…ustom uniswap forks
@ErikBjare ErikBjare changed the title feat: initial support for Honeyswap (on xDai) and specific routes feat: initial support for custom deployments May 4, 2021
@ErikBjare
ErikBjare marked this pull request as ready for review May 4, 2021 12:13
@ErikBjare

ErikBjare commented May 4, 2021

Copy link
Copy Markdown
Member Author

Tests pass locally (after fixing what I thought was the cause of #88). Not sure why they don't work in CI.

Maybe because the token is secret and not available in PRs?

Works now anyway, merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare
ErikBjare merged commit 00c77d6 into uniswap-python:master May 4, 2021
@ErikBjare
ErikBjare deleted the dev/honeyswap branch May 4, 2021 12:13
This was referenced May 4, 2021
CI tests fail in PRs #88
Closed
Multihop feature request #69
Closed
@ErikBjare ErikBjare changed the title feat: initial support for custom deployments feat: initial support for custom deployments and routes May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ErikBjare
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.