GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Feature - include/exclude objects and schemas by regex by lwasylow · Pull Request #1186 · utPLSQL/utPLSQL

Conversation

lwasylow commented Feb 9, 2022

Copy link

Copy Markdown

Member

Adding support for inclusion and exclusion of objects and schemas using regex.

begin
  ut.run(
    a_path => 'unit_test_schema', 
    a_reporter => ut_coverage_html_reporter(), 
    a_include_schema_expr => '(user_...)|(..._user)',
    a_include_object_expr => '(bonus.*)|(.*_process_.*)',
    a_exclude_schema_expr => '(user_t..)|(t.._user)',
    a_exclude_object_expr => '(.*award.*)|(.*calc.*)'
  );
end;

Current approach is that a_include_object_expr and a_include_schema_expr silently overwrites a_include_object_expr

Closes #1053

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Initial checkin for exclude objects regex.

0c57a9c

codecov Bot commented Feb 9, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Merging #1186 (2533638) into develop (cc75f85) will decrease coverage by 0.38%.
The diff coverage is 93.93%.

@@             Coverage Diff             @@
##           develop    #1186      +/-   ##
===========================================
- Coverage    94.77%   94.39%   -0.39%     
===========================================
  Files          104      107       +3     
  Lines         4881     5063     +182     
  Branches        22       22              
===========================================
+ Hits          4626     4779     +153     
- Misses         247      277      +30     
+ Partials         8        7       -1

Flag	Coverage Δ
11XE	`93.67% <93.93%> (-0.49%)`	⬇️
12.1EE	`93.69% <93.93%> (-0.42%)`	⬇️
18XE	`94.02% <93.93%> (-0.40%)`	⬇️
21XE	`94.19% <93.93%> (-0.41%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
source/api/ut.pkb	`93.26% <ø> (ø)`
source/api/ut_runner.pkb	`95.32% <ø> (+1.86%)`	⬆️
source/core/coverage/ut_coverage.pkb	`97.05% <93.10%> (+15.00%)`	⬆️
source/core/types/ut_coverage_options.tpb	`100.00% <100.00%> (+15.78%)`	⬆️
...ource/reporters/ut_coverage_report_html_helper.pkb	`52.77% <0.00%> (ø)`
source/reporters/ut_coverage_html_reporter.tpb	`88.88% <0.00%> (ø)`
source/reporters/ut_coveralls_reporter.tpb	`74.28% <0.00%> (ø)`
source/core/ut_utils.pkb	`94.44% <0.00%> (+0.25%)`	⬆️
...ource/reporters/ut_coverage_cobertura_reporter.tpb	`96.96% <0.00%> (+3.03%)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d72e3...2533638. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Feb 9, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Unit Test Results

      1 files       2 suites 3m 5s ⏱️
1 039 tests 1 035 ✔️ 4 💤 0 ❌
1 042 runs 1 034 ✔️ 8 💤 0 ❌

Results for commit 2533638.

♻️ This comment has been updated with latest results.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lwasylow added 2 commits

February 22, 2022 11:21


          commit changes

8370aa9


          Merge branch 'develop' of https://github.com/utPLSQL/utPLSQL into fea…

fc7bee9

…ture/1053_exclude_include_cov_by_regex

Adding supporting tests

jgebal reviewed

Feb 23, 2022

View reviewed changes

Comment thread

source/core/coverage/ut_coverage.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.

jgebal reviewed

Feb 23, 2022

View reviewed changes

Comment thread

source/core/coverage/ut_coverage.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.

jgebal reviewed

Feb 23, 2022

View reviewed changes

Comment thread

source/core/coverage/ut_coverage.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.

jgebal commented Feb 23, 2022

Copy link

Copy Markdown

Member

@lwasylow
It would probably be good to have those new parameters exposed in utPLSQLcli/SQLDeveloper/PL-SQLDeveloper/maven-plugin.

Can you open issues in corresponding projects, once this PR is complete and merged?

lwasylow reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jgebal reviewed

Feb 23, 2022

View reviewed changes

Comment thread

source/core/coverage/ut_coverage.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.

lwasylow added 3 commits

February 25, 2022 00:05


          Making more changes

7b9e085


          Update to code to address sql injection concerns.

4eec03e

Dealing with precedence.
Adding some more tests.


          Splitting skipped framework objects and excluded objects into separat…

e7d59b4

…e table types.

Update docs.

jgebal added this to the 3.1.13 milestone

Feb 25, 2022

jgebal reviewed

Feb 25, 2022

View reviewed changes

Comment thread

source/core/types/ut_coverage_options.tps Resolved

Uh oh!

There was an error while loading. Please reload this page.

jgebal added 2 commits

February 26, 2022 01:25


          Update of coverage documentation

6f5b2dc


          Fixed typo in documentation

b430b43

jgebal changed the title ~~Initial checkin for exclude objects regex.~~ Feature - include/exclude objects and schemas by regex

Feb 26, 2022

jgebal added the enhancement label

Feb 26, 2022

jgebal and others added 11 commits

February 26, 2022 02:57


          Merge remote-tracking branch 'origin/develop' into feature/1053_exclu…

efa78a3

…de_include_cov_by_regex


          Added ability to publish coverage generated by test jobs running utPL…

4ab0f58

…SQL with coverage into main testing session coverage.


          Merge remote-tracking branch 'origin/develop' into feature/1053_exclu…

5201f2a

…de_include_cov_by_regex


          Adding extra tests for code coverage

a84246b


          Added extra coverage for file mapping.

090207c


          g_coverage_run_id is now reset after coverage collection is stopped.

df31fba


          Improved coverage collection scope and stability on self-tests for ut…

0a2f478

…PLSQL


          Coverage documentation improvements.

bd05e4c

Fixed datatype for ut_coverage_options.tps attributes
Formatting.


          Coverage documentation improvements.

3b9b626


          Fixing flaky test

3bdb9d0


          Update of coverage.md

7cca6b4


          Update coverage.md

sonarqubecloud Bot commented Mar 2, 2022

Copy link

Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

95.2% Coverage
0.0% Duplication

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jgebal merged commit 428eda5 into develop

Mar 2, 2022

jgebal deleted the feature/1053_exclude_include_cov_by_regex branch

March 3, 2022 00:09

Reviewers

jgebal

jgebal left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v3.1.13

Development

Successfully merging this pull request may close these issues.

Exclude Objects from code coverage by wildcard

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

lwasylow commented Feb 9, 2022

Uh oh!

codecov Bot commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jgebal commented Feb 23, 2022

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 2, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Feb 9, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Feb 9, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.