GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix uninstall scripts by jgebal · Pull Request #1221 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Jul 28, 2022

Copy link
Copy Markdown
Member

Fixing problem with uninstall script buffer overflow on DBMS_OUTPUT.
Resolves: #1220

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
Fix uninstall scripts
4f944a6 
Fixing problem with uninstall script buffer overflow on DBMS_OUTPUT.
Reolves: #1220
@jgebal jgebal added this to the 3.1.13 milestone Jul 28, 2022
@github-actions

github-actions Bot commented Jul 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files         2 suites   4m 31s ⏱️
1 025 tests 1 020 ✔️ 4 💤 0 ❌ 1 🔥
1 028 runs  1 019 ✔️ 8 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 4f944a6.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kukimik

kukimik commented Jul 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Note that with serveroutput turned off, failure to drop a synonym is likely to get unnoticed. See the error handling in uninstall_synonyms.sql:

utPLSQL/source/uninstall_synonyms.sql

Line 22 in fc5c4af

exception
,

utPLSQL/source/uninstall_synonyms.sql

Line 55 in fc5c4af

exception
- the exceptions are silenced.

By the way, also this i := i + 1; should be put after execute immediate succeeds. Maybe it can also be fixed here. Mentioning any failures in the summaries ( dbms_output.put_line(i||' synonyms dropped');) could also be helpful.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal

jgebal commented Jul 29, 2022

Copy link
Copy Markdown
Member Author

Note that with serveroutput turned off,...

It won't as the output is enabled as unlimited inthis script.
https://github.com/utPLSQL/utPLSQL/blob/develop/source/uninstall.sql#L17
https://github.com/utPLSQL/utPLSQL/blob/develop/source/define_ut3_owner_param.sql#L17
kukimik reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
jgebal merged commit bffce59 into develop Aug 8, 2022
@jgebal
jgebal deleted the jgebal-patch-1 branch August 15, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.13

Development

Successfully merging this pull request may close these issues.

Uninstall script: buffer overflow error

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jgebal @kukimik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.