GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes to DDL Trigger annotation parsing on 11g by jgebal · Pull Request #1093 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Aug 3, 2020

Copy link
Copy Markdown
Member

Resolves #1088

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jgebal added 2 commits August 3, 2020 17:38
@jgebal
Fixes to annotation parsing.
81d4194 
Resolves #1088

Changed tests to reproduce issue with `dbms_preprocessor` failing to parse source that start with:
`package owner.name authid definer is ...`
@jgebal
Fixed issue by removing owner from beginning of source code.
86e335e
@jgebal jgebal added this to the 3.1.11 milestone Aug 3, 2020
@jgebal jgebal added the bugfix label Aug 3, 2020
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PhilippSalvisberg
PhilippSalvisberg approved these changes Aug 3, 2020
View reviewed changes

@PhilippSalvisberg PhilippSalvisberg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
jgebal merged commit 74b77b5 into develop Aug 9, 2020
@jgebal
jgebal deleted the feature/fix_ddl_trigger_parsing branch August 9, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

v3.1.11

Development

Successfully merging this pull request may close these issues.

DDL Trigger not working

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jgebal @PhilippSalvisberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.