GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Feature/1082 failure when comparing nested objects by lwasylow · Pull Request #1179 · utPLSQL/utPLSQL

Conversation

@lwasylow

@lwasylow lwasylow commented Jan 26, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixing issue where code was failing on the nested objects due to "object" type being pulled into dynamic SQL as datatype to extract into.

Fixing issue when null value was passed to get_hash function causing compare to fail

Address a possible scenario when more than 2 levels of nesting for same objects caused ambiguity of the column name.

Closing #1082
Closing #1098
Closing #1083

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lwasylow added 4 commits January 26, 2022 00:37
@lwasylow
Initial check in.
c11aa24 
Covers issues of displaying wrong info in diff message for nested objects.
Exclude object type from being part of the SQL generation.
@lwasylow
Adding test for double nested objects
e0ac97c
@lwasylow
Fixing test object name as its too large for 11gR2 (31 char)
5e983a8
@lwasylow
Fixing issue when a hash was tried to be generated on the null value …
3c3d320 
…from XML extract causing to fail. Please see #1098

Resolve a situation where a more than two levels of nesting were causing ambiguity on the column name for hash.
E.g.
<OBJ1><FIRST><VAL><TEST>
<OBJ1><SECOND><VAL><TEST>
Was taking into hash consideration only parent.
@lwasylow
lwasylow requested a review from jgebal January 26, 2022 11:21
This was linked to issues Jan 26, 2022
Failure when comparing nested objects #1082
Closed
fails when a grand child nested type have NULL #1098
Closed
@lwasylow
lwasylow requested review from PhilippSalvisberg, pesse and simasch January 26, 2022 11:31
simasch
simasch approved these changes Jan 26, 2022
View reviewed changes
@lwasylow
Fixing issue when a collection nested inside object was failing due t…
14b0b8d 
…o fact that there was no name for collection columns as part of cursor only data type.

Added extra tests.
@lwasylow lwasylow linked an issue Jan 26, 2022 that may be closed by this pull request
Unreadable & misleading results when comparing nested objects #1083
Closed
@sonarqubecloud

sonarqubecloud Bot commented Jan 26, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lwasylow
Removing empty line from code.
85b2349
@sonarqubecloud

sonarqubecloud Bot commented Jan 26, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal

jgebal commented Jan 28, 2022

Copy link
Copy Markdown
Member

Let me have a deeper look into that PR before I approve it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jgebal
jgebal requested changes Jan 28, 2022
View reviewed changes
Comment thread test/ut3_user/expectations/test_expectation_anydata.pks Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/ut3_user/expectations/test_expectation_anydata.pks Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jgebal

jgebal commented Jan 28, 2022

Copy link
Copy Markdown
Member

I've reviewed the PR. It addresses all 3 issues.
Brilliant work @lwasylow 👌 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lwasylow added 3 commits January 28, 2022 22:49
@lwasylow
Address PR comments
c14a3ad
@lwasylow
Creating regression test scenario for fixed issue 1098 and supporting…
a2cf02e 
… test types.
@lwasylow
Fixing an 11g limit on size of the procedure of 30.
b11e799
@sonarqubecloud

sonarqubecloud Bot commented Jan 29, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lwasylow
lwasylow requested a review from jgebal January 29, 2022 19:42
jgebal
jgebal approved these changes Jan 29, 2022
View reviewed changes
@jgebal jgebal added this to the 3.1.12 milestone Jan 29, 2022
@lwasylow
lwasylow merged commit 4d55bf4 into develop Jan 29, 2022
@lwasylow
lwasylow deleted the feature/1082_failure_when_comparing_nested_objects branch January 29, 2022 21:08
@jgebal jgebal added the bugfix label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes
@pesse pesse Awaiting requested review from pesse
@PhilippSalvisberg PhilippSalvisberg Awaiting requested review from PhilippSalvisberg
+1 more reviewer
@simasch simasch simasch approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

v3.1.12

Development

Successfully merging this pull request may close these issues.

fails when a grand child nested type have NULL Unreadable & misleading results when comparing nested objects Failure when comparing nested objects

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lwasylow @jgebal @simasch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.