GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support native JSON data type of Oracle Database 21c by lwasylow · Pull Request #1181 · utPLSQL/utPLSQL

Conversation

@lwasylow

@lwasylow lwasylow commented Feb 1, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Introducing a support for native json in 21c.
Fixing issue with act and exp
Closes #1114
Closes #1113

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lwasylow added 6 commits January 31, 2022 00:42
@lwasylow
First commit of adding a new 21c json type.
9b8d7f7
@lwasylow
Update install on 11c to add new json type.
3d3f0be
@lwasylow
Making tests below 21 compilation conditional so it wont fail.
9002fbc
@lwasylow
Fixing conditional compilation
b270d4e
@lwasylow
Missing return from function.
5b1c1d3
@lwasylow
Added mention about new type into userguide.
0d8cbea
@lwasylow
lwasylow requested review from Pazus, PhilippSalvisberg and jgebal February 1, 2022 01:02
@lwasylow lwasylow linked an issue Feb 1, 2022 that may be closed by this pull request
Support native JSON data type of Oracle Database 21c #1114
Closed
@lwasylow
Fixing sonar.
21b3cb3
@lwasylow
lwasylow requested review from PhilippSalvisberg, jgebal and pesse and removed request for Pazus, PhilippSalvisberg and jgebal February 1, 2022 08:06
lwasylow added 2 commits February 1, 2022 19:58
@lwasylow
Adding conditional execution of sonarcloud.
075fe52
@lwasylow
Fixing issue 1113 where the act were inserted into exp
dc14dc7
@sonarqubecloud

sonarqubecloud Bot commented Feb 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal

jgebal commented Feb 5, 2022

Copy link
Copy Markdown
Member

Can you also add a comment to the documentation related to the fact that DB upgrade will require utPLSQL to be re-installed?

If you're on say 18c and go to 21c, utPLSQL new features (native JSON) will not work without reinstall.
This is because we create a local stub type for JSON on lower versions of oracle.
The same rule applies for upgrade to 12.2, where JSON was initially introduced (JSON_Element_T).

A note on the upgrade of DB with utPLSQL will definitely help.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
Merge branch 'develop' into feature/1114_support_native_json_21c
a08545c
jgebal
jgebal approved these changes Feb 6, 2022
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Feb 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #1181 (e44830b) into develop (d81824a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1181   +/-   ##
========================================
  Coverage    94.85%   94.86%           
========================================
  Files          104      104           
  Lines         4844     4853    +9     
  Branches        21       21           
========================================
+ Hits          4595     4604    +9     
  Misses         241      241           
  Partials         8        8
Flag Coverage Δ
11xe 94.17% <0.00%> (-0.06%) ⬇️
18xe 94.53% <0.00%> (-0.16%) ⬇️
21xe 94.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/api/ut.pkb 93.26% <100.00%> (+0.06%) ⬆️
...pectations/data_values/ut_compound_data_helper.pkb 98.68% <100.00%> (+0.01%) ⬆️
...ce/expectations/data_values/ut_data_value_json.tpb 98.46% <100.00%> (+0.07%) ⬆️
source/expectations/matchers/ut_equal.tpb 100.00% <100.00%> (ø)
source/expectations/ut_expectation.tpb 98.74% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81824a...e44830b. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Feb 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files  ±  0         2 suites  ±0   1m 32s ⏱️ - 1m 11s
1 022 tests +31  1 018 ✔️ +31  4 💤 ±0  0 ❌ ±0 
1 025 runs  +31  1 017 ✔️ +31  8 💤 ±0  0 ❌ ±0 

Results for commit e44830b. ± Comparison against base commit d81824a.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jgebal
jgebal reviewed Feb 6, 2022
View reviewed changes
Comment thread source/expectations/data_values/ut_compound_data_helper.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.
lwasylow added 2 commits February 6, 2022 16:09
@lwasylow
Update test coverage and documentation
cbe03e8
@lwasylow
Merge branch 'feature/1114_support_native_json_21c' of https://github…
e44830b 
….com/utPLSQL/utPLSQL into feature/1114_support_native_json_21c
@sonarqubecloud

sonarqubecloud Bot commented Feb 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lwasylow
lwasylow merged commit ab1acfa into develop Feb 6, 2022
@jgebal
jgebal deleted the feature/1114_support_native_json_21c branch February 6, 2022 18:51
@jgebal jgebal added this to the 3.1.12 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes
@pesse pesse Awaiting requested review from pesse
@PhilippSalvisberg PhilippSalvisberg Awaiting requested review from PhilippSalvisberg

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.12

Development

Successfully merging this pull request may close these issues.

Support native JSON data type of Oracle Database 21c Actual reported as expected and vice versa for JSON_ELEMENT_T

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lwasylow @jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.