GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added disabledReason to `ut_realtime_reporter` by jgebal · Pull Request #1193 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Feb 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The ut_realtime_reporter used by utPLSQL-SQL-Developer-extension and utPLSQL-PLSQL-Developer-plugin is now capable of providing reason for a disabled test.
The reason is provided as a tag <disabledReason>reason</disabledReason> in the pre-run event, describing the suites before run is started.

If no reason is provided, the tag is not present in the output.

Resolves: #1192

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal jgebal added the enhancement label Feb 25, 2022
@jgebal jgebal added this to the 3.1.13 milestone Feb 25, 2022
@jgebal
jgebal requested review from PhilippSalvisberg and lwasylow February 25, 2022 16:53
@jgebal jgebal self-assigned this Feb 25, 2022
@github-actions

github-actions Bot commented Feb 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files      2 suites   2m 32s ⏱️
   999 tests 995 ✔️ 4 💤 0 ❌
1 002 runs  994 ✔️ 8 💤 0 ❌

Results for commit 7e680ee.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
Added disabledReason to ut_realtime_reporter
7e680ee
@jgebal
jgebal force-pushed the feature/disable_reason_in_realtime_reporter branch from e4de2f4 to 7e680ee Compare February 25, 2022 17:04
@codecov

codecov Bot commented Feb 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #1193 (7e680ee) into develop (ca3dec7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1193      +/-   ##
===========================================
+ Coverage    94.77%   94.79%   +0.02%     
===========================================
  Files          104      104              
  Lines         4878     4879       +1     
  Branches        22       22              
===========================================
+ Hits          4623     4625       +2     
  Misses         247      247              
+ Partials         8        7       -1
Flag Coverage Δ
11XE 94.22% <100.00%> (+0.10%) ⬆️
12.1EE 94.26% <100.00%> (+0.04%) ⬆️
18XE 94.41% <100.00%> (+<0.01%) ⬆️
21XE 94.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/reporters/ut_realtime_reporter.tpb 100.00% <100.00%> (ø)
source/core/ut_utils.pkb 94.44% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd81df2...7e680ee. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sonarqubecloud

sonarqubecloud Bot commented Feb 25, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lwasylow
lwasylow approved these changes Feb 25, 2022
View reviewed changes
PhilippSalvisberg
PhilippSalvisberg approved these changes Feb 25, 2022
View reviewed changes

@PhilippSalvisberg PhilippSalvisberg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks a lot @jgebal 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
jgebal merged commit b2d318c into develop Feb 25, 2022
@jgebal
jgebal deleted the feature/disable_reason_in_realtime_reporter branch February 25, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes
@lwasylow lwasylow lwasylow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jgebal jgebal

Labels

enhancement

Projects

None yet

Milestone

v3.1.13

Development

Successfully merging this pull request may close these issues.

Extend ut_realtime_reporter to include disabled reason

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jgebal @PhilippSalvisberg @lwasylow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.