GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Removed test users env variables by jgebal · Pull Request #1201 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Mar 13, 2022

Copy link
Copy Markdown
Member

Those variables are not needed and bring no real benefit asu the usernames actually cannot be configured and even if they were, there would be no real benefit to it.
Resolves: #1200

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
Removed test users env variables
61ce1bb 
Those variables are not needed and bring no real benefit asu the usernames actually cannot be configured and even if they were, there would be no real benefit to it.
@jgebal jgebal added the bugfix label Mar 13, 2022
@jgebal jgebal added this to the 3.1.13 milestone Mar 13, 2022
@jgebal
jgebal requested a review from PhilippSalvisberg March 13, 2022 23:14
@jgebal jgebal self-assigned this Mar 13, 2022
@github-actions

github-actions Bot commented Mar 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files         2 suites   3m 44s ⏱️
1 008 tests 1 004 ✔️ 4 💤 0 ❌
1 011 runs  1 003 ✔️ 8 💤 0 ❌

Results for commit 61ce1bb.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Mar 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #1201 (61ce1bb) into develop (ed93645) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1201      +/-   ##
===========================================
+ Coverage    94.37%   94.39%   +0.01%     
===========================================
  Files          107      107              
  Lines         5063     5063              
  Branches        22       22              
===========================================
+ Hits          4778     4779       +1     
  Misses         277      277              
+ Partials         8        7       -1
Flag Coverage Δ
11XE 93.76% <ø> (+0.06%) ⬆️
12.1EE 93.69% <ø> (+0.04%) ⬆️
18XE 94.02% <ø> (ø)
21XE 94.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/ut_utils.pkb 94.44% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fd36d...61ce1bb. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PhilippSalvisberg
PhilippSalvisberg approved these changes Mar 13, 2022
View reviewed changes
@sonarqubecloud

sonarqubecloud Bot commented Mar 13, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
jgebal merged commit 515c4bc into develop Mar 14, 2022
@jgebal
jgebal deleted the feature/cleanup_env branch March 14, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jgebal jgebal

Labels

bugfix

Projects

None yet

Milestone

v3.1.13

Development

Successfully merging this pull request may close these issues.

Cannot install tests when using default user names as provided in template.env.sh

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jgebal @PhilippSalvisberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.