GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ability to report coverage on long lines. by jgebal · Pull Request #1240 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Oct 18, 2022

Copy link
Copy Markdown
Member

Sourcecode lines that result in more than 4000 chars after conversion to HTML should be reported successfully.
Resolves: #1232

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
Ability to report coverage on long lines.
24fa8ff 
Sourcecode lines that result in more than 4000 chars after conversion to HTML should be reported successfully.
Resolves: #1232
@jgebal jgebal added the bugfix label Oct 18, 2022
@jgebal jgebal added this to the 3.1.13 milestone Oct 18, 2022
@jgebal
jgebal requested a review from PhilippSalvisberg October 18, 2022 21:34
@jgebal jgebal self-assigned this Oct 18, 2022
@github-actions

github-actions Bot commented Oct 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files         2 suites   2m 44s ⏱️
1 051 tests 1 047 ✔️ 4 💤 0 ❌
1 054 runs  1 046 ✔️ 8 💤 0 ❌

Results for commit 8270715.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Oct 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Base: 94.45% // Head: 95.13% // Increases project coverage by +0.67% 🎉

Coverage data is based on head (8270715) compared to base (e71571a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1240      +/-   ##
===========================================
+ Coverage    94.45%   95.13%   +0.67%     
===========================================
  Files          108      108              
  Lines         5089     5093       +4     
  Branches        22       22              
===========================================
+ Hits          4807     4845      +38     
+ Misses         274      240      -34     
  Partials         8        8
Flag Coverage Δ
11XE 94.52% <100.00%> (+0.77%) ⬆️
12.1EE 94.54% <100.00%> (+0.77%) ⬆️
18XE 94.78% <100.00%> (+0.67%) ⬆️
21XE 94.96% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ource/reporters/ut_coverage_report_html_helper.pkb 80.35% <100.00%> (+27.57%) ⬆️
source/core/ut_utils.pkb 94.44% <0.00%> (+0.24%) ⬆️
source/core/coverage/ut_coverage_helper.pkb 100.00% <0.00%> (+15.38%) ⬆️
source/core/types/ut_object_name.tpb 100.00% <0.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
Fixing name that was too long for the test before 12.2
8270715
@sonarqubecloud

sonarqubecloud Bot commented Oct 18, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PhilippSalvisberg
PhilippSalvisberg approved these changes Oct 19, 2022
View reviewed changes

@PhilippSalvisberg PhilippSalvisberg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgebal looks good. Thank you very much!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
jgebal merged commit 65db189 into develop Oct 19, 2022
@jgebal
jgebal deleted the bugfix/coverage_html_report_on_long_lines branch October 19, 2022 20:13
@jgebal jgebal mentioned this pull request Oct 26, 2022
ORA-19011: Character string buffer too small returned when generating coverage report #1087
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jgebal jgebal

Labels

bugfix

Projects

None yet

Milestone

v3.1.13

Development

Successfully merging this pull request may close these issues.

ut_coverage_html_reporter crashes when code under test contain lines larger than 1911 characters

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jgebal @PhilippSalvisberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.