GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow for test runs over 4 hours by jgebal · Pull Request #1243 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Feb 8, 2023

Copy link
Copy Markdown
Member

Resolves #1242

Refactored output buffers to have better segregation of responsibilities.

Changed behavior of output buffers get_lines procedure to stop immediately after consuming all produced data if producer has stopped.
Changed behavior of output buffers get_lines procedure not to timeout after 4 hours, if producer is still running.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
Refactored output buffers to have better segregation of responsibilit…
da6ee70 
…ies.

Changed behavior of output buffer `get_lines` procedure to stop immediately after consuming all produced data if producer has stopped.
Changed behavior of output buffer `get_lines` procedure not to timeout after 4 hours, if producer is still running.
@github-actions

github-actions Bot commented Feb 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files         2 suites   5m 21s ⏱️
1 027 tests 1 023 ✔️ 4 💤 0 ❌
1 030 runs  1 022 ✔️ 8 💤 0 ❌

Results for commit 865785a.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
Update RunExampleTestSuiteWithCompositeReporter.sql
a64bd14
@codecov

codecov Bot commented Feb 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Base: 95.13% // Head: 94.84% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (865785a) compared to base (315e5c6).
Patch coverage: 91.08% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1243      +/-   ##
===========================================
- Coverage    95.13%   94.84%   -0.29%     
===========================================
  Files          108      108              
  Lines         5093     5105      +12     
  Branches        22       23       +1     
===========================================
- Hits          4845     4842       -3     
- Misses         240      255      +15     
  Partials         8        8
Flag Coverage Δ
11XE 94.27% <90.90%> (-0.24%) ⬇️
12.1EE 94.20% <90.90%> (-0.28%) ⬇️
18XE 94.48% <90.09%> (-0.31%) ⬇️
21XE 94.66% <90.09%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/coverage/ut_coverage_reporter_base.tpb 100.00% <ø> (ø)
...urce/core/output_buffers/ut_output_buffer_base.tpb 76.78% <77.14%> (-23.22%) ⬇️
...rce/core/output_buffers/ut_output_table_buffer.tpb 83.33% <97.14%> (-3.11%) ⬇️
...ore/output_buffers/ut_output_clob_table_buffer.tpb 95.74% <100.00%> (-2.51%) ⬇️
source/core/types/ut_output_reporter_base.tpb 78.94% <100.00%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jgebal added 4 commits February 10, 2023 01:31
@jgebal
Extended schediler job timeout to 10 minutes to allow for slow execut…
c1d5ab6 
…ion on older DB versions.

We should investigate to see why execution is so slow on 11.2 and 12.1
@jgebal
Improving performance of output buffer processing.
99447ed
@jgebal
Fixed performance issues introduced with previous refactoring.
07f79e2
@jgebal
Fixed failing test.
865785a
@sonarqubecloud

sonarqubecloud Bot commented Feb 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.2% 94.2% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
jgebal marked this pull request as ready for review February 11, 2023 10:48
@jgebal
jgebal merged commit 5cf7f34 into develop Feb 11, 2023
@jgebal
jgebal deleted the feature/output_buffer_sync branch February 11, 2023 10:48
@jgebal jgebal added this to the v3.1.14 milestone May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.14

Development

Successfully merging this pull request may close these issues.

Timeout after 4 hours on reporter waiting for data

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.