GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Address issue where the not_to(contain) not run correctly by lwasylow · Pull Request #1246 · utPLSQL/utPLSQL

Conversation

@lwasylow

@lwasylow lwasylow commented Mar 15, 2023

Copy link
Copy Markdown
Member

Address issue where the not_to(contain) executes a negated matcher wi…thout negated flag set causing refcursor compare sql generated inclusion comparision.
fixes #1245

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lwasylow
Address issue where the not_to(contain) executes a negated matcher wi…
3a837f4 
…thout negated flag set causing refcursor compare sql generated inclusion comparision.
@lwasylow
lwasylow requested a review from jgebal March 15, 2023 06:12
@github-actions

github-actions Bot commented Mar 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files         2 suites   5m 8s ⏱️
1 034 tests 1 030 ✔️ 4 💤 0 ❌
1 037 runs  1 029 ✔️ 8 💤 0 ❌

Results for commit 8460a30.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Mar 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (5cf7f34) 94.86% compared to head (8460a30) 94.88%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1246      +/-   ##
===========================================
+ Coverage    94.86%   94.88%   +0.02%     
===========================================
  Files          108      108              
  Lines         5105     5106       +1     
  Branches        23       23              
===========================================
+ Hits          4843     4845       +2     
+ Misses         255      254       -1     
  Partials         7        7
Flag Coverage Δ
11XE 94.25% <100.00%> (+0.08%) ⬆️
12.1EE 94.31% <100.00%> (+0.04%) ⬆️
18XE 94.50% <100.00%> (+0.02%) ⬆️
21XE 94.68% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/expectations/matchers/ut_contain.tpb 88.23% <100.00%> (+0.73%) ⬆️
source/expectations/ut_expectation.tpb 99.37% <100.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lwasylow added 2 commits March 14, 2023 23:19
@lwasylow
Fixing when test name is longer than 30 char
0707b2d
@lwasylow
Update test
8460a30
@sonarqubecloud

sonarqubecloud Bot commented Mar 15, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jgebal
jgebal reviewed Mar 15, 2023
View reviewed changes
Comment thread test/ut3_user/expectations/test_expectation_anydata.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.
jgebal
jgebal approved these changes Mar 19, 2023
View reviewed changes
@jgebal
jgebal merged commit 6d77183 into develop Mar 19, 2023
@jgebal
jgebal deleted the bug/1245_not_to_contains_fails branch March 19, 2023 16:55
@jgebal jgebal added this to the v3.1.14 milestone May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.14

Development

Successfully merging this pull request may close these issues.

not_to(contain) fails while not_to_contain passes

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lwasylow @jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.