GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix regex to be NLS_SORT independent by jgebal · Pull Request #1253 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented May 21, 2023

Copy link
Copy Markdown
Member

Resolves #1252
Replaced all regexp ranges with posix representations to avoid NLS_SORT impact on regex behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgebal
Resolves #1252
962f6fd 
Replaced all regexp ranges with posix representations to avoid NLS_SORT impact on regex behavior.
@jgebal jgebal added this to the v3.1.14 milestone May 21, 2023
@jgebal
jgebal requested a review from lwasylow May 21, 2023 09:56
@github-actions

github-actions Bot commented May 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files         2 suites   5m 5s ⏱️
1 049 tests 1 045 ✔️ 4 💤 0 ❌
1 053 runs  1 045 ✔️ 8 💤 0 ❌

Results for commit 962f6fd.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented May 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (320b3b0) 94.67% compared to head (962f6fd) 94.69%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1253      +/-   ##
===========================================
+ Coverage    94.67%   94.69%   +0.01%     
===========================================
  Files          111      111              
  Lines         5374     5374              
  Branches        33       33              
===========================================
+ Hits          5088     5089       +1     
  Misses         278      278              
+ Partials         8        7       -1
Flag Coverage Δ
11XE 94.27% <80.00%> (ø)
12.1EE 94.33% <80.00%> (+0.05%) ⬆️
18XE 94.50% <100.00%> (ø)
21XE 94.67% <100.00%> (ø)
23free 94.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/ut_metadata.pkb 89.88% <ø> (ø)
source/core/annotations/ut_annotation_manager.pkb 98.91% <100.00%> (ø)
source/core/annotations/ut_annotation_parser.pkb 95.94% <100.00%> (ø)
source/core/types/ut_executable_test.tpb 94.28% <100.00%> (ø)
source/core/ut_expectation_processor.pkb 100.00% <100.00%> (ø)
source/core/ut_suite_cache_manager.pkb 97.01% <100.00%> (ø)
source/core/ut_suite_manager.pkb 96.29% <100.00%> (ø)
source/core/ut_utils.pkb 94.74% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sonarqubecloud

sonarqubecloud Bot commented May 21, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
jgebal merged commit 020150f into develop May 27, 2023
@jgebal
jgebal deleted the bugfix/regex_fail_on_nls_sort branch May 27, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwasylow lwasylow Awaiting requested review from lwasylow

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.14

Development

Successfully merging this pull request may close these issues.

The functionality of utPLSQL is dependent on the session parameter NLS_SORT

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.