GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable duplicate detection on cursor comparison using join by by lwasylow · Pull Request #1295 · utPLSQL/utPLSQL

Conversation

@lwasylow

@lwasylow lwasylow commented Apr 3, 2025

Copy link
Copy Markdown
Member

Resolves #1293
In certain scenarios when the data sets are identical but have an duplicate rows, the cursors join_by when doing join in SQL joined only by PK which resulted on full match from differences query.
Extended a PK join by to the duplicate number to make sure we match on the rows number.

Testing case was added however due to issue with a cursor comparison inside the logic the case will fail until merged into develop.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lwasylow added 2 commits April 2, 2025 20:41
@lwasylow
Adding tests for issue 1293
39ff2ed
@lwasylow
For a join by key we need to also compare by duplicate numbers to mak…
85734ff 
…e sure that we have same amount of rows when rows are identical but row counts is different.
@lwasylow
lwasylow requested a review from jgebal April 3, 2025 17:45
@lwasylow lwasylow self-assigned this Apr 3, 2025
@github-actions

github-actions Bot commented Apr 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files  ±  0         2 suites  ±0   1m 57s ⏱️ - 1m 24s
1 090 tests +34  1 086 ✔️ +34  4 💤 ±0  0 ❌ ±0 
1 094 runs  +34  1 086 ✔️ +34  8 💤 ±0  0 ❌ ±0 

Results for commit 6f273df. ± Comparison against base commit 31604c6.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Apr 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (31604c6) to head (6f273df).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1295   +/-   ##
========================================
  Coverage    94.97%   94.97%           
========================================
  Files          111      111           
  Lines         5396     5396           
  Branches        34       34           
========================================
  Hits          5125     5125           
  Misses         271      271
Flag Coverage Δ
11XE 94.44% <100.00%> (+0.07%) ⬆️
12.1EE 94.50% <100.00%> (+0.15%) ⬆️
18XE 95.09% <100.00%> (ø)
21XE 95.24% <100.00%> (ø)
23free 94.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal

jgebal commented Apr 3, 2025

Copy link
Copy Markdown
Member

Build is failing on 11 and 12 because procedure name is too long.
Until we officially drop support for 11, 12, we need main the compatibility.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lwasylow
Change procedure nameto be less 30 to work for 11 and 12
6f273df
@lwasylow

lwasylow commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

People getting use to good things to quickly :) Updated
jgebal reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jgebal
jgebal approved these changes Apr 3, 2025
View reviewed changes
@jgebal
jgebal merged commit e872b30 into develop Apr 3, 2025
@lwasylow
lwasylow deleted the feature/issue_1293 branch April 4, 2025 20:17
@lwasylow
lwasylow restored the feature/issue_1293 branch April 4, 2025 20:17
@jgebal
jgebal deleted the feature/issue_1293 branch April 22, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@lwasylow lwasylow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cursor comparison not detecting duplicate rows

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lwasylow @jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.