GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed issue with parsing via trigger source with leading comments by jgebal · Pull Request #940 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Jun 16, 2019

Copy link
Copy Markdown
Member

Resolves problem when sources are passed via JDBC or dynamic SQL for compilation and source code contains leading comments.
The code was adjusted to properly read sources even when they are getting passed with leading comments containing create package statement.
Now, the following will be properly parsed:

  begin
    execute immediate q'[
      /*
      * Some multiline comments before package spec
      create or replace package dummy_test_package dummy comment to prove that we pick the right piece of code
      */
      -- create or replace package dummy_test_package dummy comment to prove that we pick the right piece of code
      --Some single-line comment before package spec
      create or replace package dummy_test_package as
        --%suite(dummy_test_suite)
        --%rollback(manual)

        --create or replace package dummy_test_package dummy comment to prove that we pick the right piece of code
        
        --%test(dummy_test)
        --%beforetest(some_procedure)
        procedure some_dummy_test_procedure;
      end;]';
  end;
/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jgebal
Fixed issue with parsing by trigger when source contains leading comm…
e0d6768
…ents.
@jgebal jgebal added this to the v3.1.7 milestone Jun 16, 2019
@jgebal
jgebal requested review from PhilippSalvisberg and lwasylow June 16, 2019 12:29
@jgebal
Fixed typo.
69c2393
lwasylow
lwasylow approved these changes Jun 16, 2019
View reviewed changes
Comment thread source/core/annotations/ut_annotation_manager.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.

@lwasylow

lwasylow commented Jun 16, 2019

Copy link
Copy Markdown
Member

In build there is some odd log out during installation :
Synonym UT_RUN_INFO created.
bash: del: command not found
Installing component UT_TRIGGER_ANNOTATION_PARSING

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lwasylow
lwasylow approved these changes Jun 16, 2019
View reviewed changes
jgebal added 2 commits June 16, 2019 19:39
@jgebal
Improved time needed for clob-to-table conversion.
a0e98ed
Timing before change (with dbms_lob.read):
`clob_to_table - Took:+000000000 00:00:00.012957000`
After change:
`clob_to_table - Took:+000000000 00:00:00.001236000`
Speed improved by order of magnitude.
@jgebal
Resolved issues with regex for DDL trigger processing.
8defe56
lwasylow
lwasylow approved these changes Jun 16, 2019
View reviewed changes
@jgebal

jgebal commented Jun 16, 2019

Copy link
Copy Markdown
Member Author

The message comes from script: define_ut3_owner_param.sql I'm not sure how else to remove temp files using sqlpls for both Win and Unix/Mac

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jgebal added 2 commits June 16, 2019 19:59
@jgebal
Fixed typo.
780cfc0
@jgebal
Merge branch 'develop' into feature/fix_ddl_triger_parser
b8de3ed
@jgebal
jgebal merged commit 683eef3 into develop Jun 17, 2019
@jgebal
jgebal deleted the feature/fix_ddl_triger_parser branch June 17, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwasylow lwasylow lwasylow approved these changes
@PhilippSalvisberg PhilippSalvisberg Awaiting requested review from PhilippSalvisberg

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.7

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jgebal @lwasylow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.