GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Feature/improve coverage source query by jgebal · Pull Request #981 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Jul 17, 2019

Copy link
Copy Markdown
Member

Resolves #970

@rafael-trevisan - Will you be able to apply the changed package body on your DB, that was causing problems and confirm that it is working as expected?

This PR includes a different solution to the one your DBA has applied but it should also work fine.
The changed query syntax also applies some readability improvements to the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jgebal added 4 commits July 16, 2019 22:40
@jgebal
Trying different approach to coverage gathering.
abba642
@jgebal
Trying different approach to coverage gathering.
a8c0c82
@jgebal
Reworked coverage sources query
f4bede0
@jgebal
simplified profiler helper - no need for dynamic SQL and explicit cur…
a95ca55 
…sor.
@jgebal jgebal added enhancement bugfix labels Jul 17, 2019
@jgebal jgebal added this to the v3.1.8 milestone Jul 17, 2019
@jgebal
jgebal requested review from PhilippSalvisberg and lwasylow July 17, 2019 22:32
@rafael-trevisan

rafael-trevisan commented Jul 17, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hi @jgebal, I confirm the change that @fabiopan has done is already in our DB and works beautifully. We've been generating the Coverage Report since the last couple days without any problem and its line number is accurate.

We did some improvement in the original workaround, so the version @fabiopan has posted is the lastest one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PhilippSalvisberg
PhilippSalvisberg approved these changes Jul 18, 2019
View reviewed changes
@PhilippSalvisberg

PhilippSalvisberg commented Jul 18, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The code is much more readable due to the code templates. And the query does not need subqueries anymore. That’s good. However, the optimizer has still the freedom to completely rewrite the statement. If this results in a bad plan (for all/dba_source access) then further named subqueries to isolate all/dba_source access with a no_merge or materialize hint might help. I’d go with this change “as is” now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PhilippSalvisberg
PhilippSalvisberg merged commit 0858701 into develop Jul 18, 2019
@PhilippSalvisberg PhilippSalvisberg mentioned this pull request Jul 18, 2019
fix #970 #980
Closed
@jgebal
jgebal deleted the feature/improve_coverage_source_query branch July 18, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes
@lwasylow lwasylow Awaiting requested review from lwasylow

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bugfix enhancement

Projects

None yet

Milestone

v3.1.8

Development

Successfully merging this pull request may close these issues.

Coverage Report doesn't run (or takes forever)

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jgebal @rafael-trevisan @PhilippSalvisberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.