GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — #65 - Alternative hierarchical view by PhilippSalvisberg · Pull Request #123 · utPLSQL/utPLSQL-SQLDeveloper

Conversation

PhilippSalvisberg commented Jan 3, 2021

Copy link

Copy Markdown

Member

Added an alternative tree-table view to the Realtime Reporter (utPLSQL Test Runner). It closes #65. The following areas are affected of this PR (from a user perspective)

Realtime Reporter
- The new tree-table view is default. It shows the all suites as a hierarchy. Tests are always leafs. Suites with the same parent identifier are collapsed to a single node, even if the suite code is executed more than once (e.g. when starting utPLSQL with a list of tests). In such a case the suite specific data is aggregated.
- The suite description is shown only for contexts and tests (if available). For other suites always the name is shown. The reason is that the description is not aggregated (only the last description of a suite is shown). This would lead to a very confusing tree representation.
- The warning and info indicator is now shown before the execution time. For the tree-table and table view. This is consistent. The order of the columns is not configurable.
- In the tree-table view sorting rows is not supported. Beside that all features work as in the table view. The settings are applied always on both views (e.g. filtering, show/hide columns).
- Suitepath optimization. This means when you select multiple items (suites and tests) it is reduced to an optimal list to avoid that test are executed multiple times.
- New button on the toolbar. Switch between hierarchical view (shows suites and tests) and tabular view (shows tests only). You can press the button anytime, even during runs. The selected row is preserved when just a single suite/test is selected (for suites the first child is considered).
- New PopUp Menu entry Show suites (hierarchical view of tests)? in the test overview section. Same action as via toolbar.
Preferences
- New preference Show suites (hierarchical view of tests)? in the Realtime Reporter section.
- The tree-table view is now the default.
Icons
- The tree-table uses the existing icons plus the following new icons in the tree component to represent group of suites, suites, contexts and tests. These icons are visible between the pre-run and the pre-test event. The icon will be replaced with one of the status icons.
- Updated icons for status, success, failure, error, disabled, warning and info. These icons share a common flat design and look nicer.
Bug fixes
- Hyperlinks in warning and info fields were activated via any mouse event. Now you need to click on a hyperlink to activate it (it worked correctly for failures and errrors).
- Flickering with multiple, parallel runs. Implemented a logic that ensures that the runner does not switch back and forth between runs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

PhilippSalvisberg added 30 commits

January 3, 2021 09:53


          smaller success icon

9b4ee55


          smaller disabled icon

e6b255d


          smaller failure icon

cce6e2c


          smaller error icon

7144b27


          new info icon matching design of success/failure/error/disabled

a8a7894


          original size of info icon (before scaling down)

bbd582d


          new warning icon matching design of success/failure/error/disabled

863d1ef


          original size of warning icon (before scaling down)

370ebcc


          new status icon matching design of success/failure/error/disabled

1d2974d


          original size of status icon (before scaling down)

fce1136


          add procedure icon representing a test in the tree

9ddf38f


          add procedure folder icon representing a context in the tree

dac7fc4


          add package icon representing a suite in the tree

da1a8a8


          add package folder icon representing a suite with multiple packages i…

ccf076c

…n the tree


          add showSuites to the preference model (tree-view yes/no)

8ec1e38


          add showSuites to the preference UI (tree-view checkbox)

79505df


          extend test for preference model (showSuites)

ad912ba


          move common fields and methods from Suite/Test to Item

a972c50


          add ItemNode class for suites/tests in a tree

e803e46


          add items and itemNodes to Run

30a2c24


          add new procedure and package icons to resource bundle

72096ba


          change label of test tab to Test/Suite in resource bundle

3c95d41


          add label and button tooltip for show suites in resource bundle

50275bc


          fix wrong Run initialization in test setup

3faa839


          add runTestHidingSuccesfulRuns test (tree-view is the new default)

c1d5f30


          add getSysdate() to StringTools (from UtplsqlRunner)

70da38a


          remove blank lines

0b8b729


          add dateTimeStringToMillis to StringTools

1749af8


          add elapsedTime to StringTools

a87d314


          add isNotBlank to StringTools

235eb0b

PhilippSalvisberg added 25 commits

January 3, 2021 10:50


          add trim (with null handling) to StringTools

fe53809


          add tests for millisToDateTimeString to StringToolsTest

4a1802e


          add tests for dateTimeStringToMillis to StringToolsTest

3daf6af


          add test for elapsedTime to StringToolsTest

17de78d


          amend expected output based on new Run model in JsonToStringStylerTest

39a707b


          add TestOverviewTreeTableModel class

e24528a


          return String instead of CharSequence for getTestIdColumnName()

535ea91


          new column order: status, description, indicators, execution time

6911f8b


          use StringTools.getSysdate()

ad5110c


          add imports for Supplier, ItemNode, Suite and reorder

d299c87


          add private logFalseCondition method used in assert statements


          process pre-suite event

51691aa


          pass item when updating runner panel

d84dc2c

This allows the runner panel to use the item instead of the run's current item.
Furthermore the panel updates the a test/suite only if an item is passed.
This improves the performance of the runner.


          add aggregation logic for suites in PostSuiteEvent

7a4fda9

Previously only tests were processed. That was enough for a representation
in a simple table. To show the run result in a tree also suites need to be
processed.


          assert test != null for PreTestEvent

c847c87

Old logic would have thrown an NullPointerException.


          assert test != null for PostTestEvent

accc46c

Old logic would have thrown an NullPointerException.


          hyperlinks in warnings require mouse click to activate

79dfab7


          hyperlinks in info (server output) require mouse click to activate

77ba5a9


          add alternative tree-table-view based on #65 to the RunnerPanel

e9a4d09

Columns in table and tree-table are shown in the same order.
This means the warning and info indicators are shown now before
the execution time column.

All features that were available for the table-view are also available
in the tree-table-view with one exception: It is not possible to sort a
tree-table. Therefore sorting is disabled for the tree-table-view.
Beside that, all  features that are available in the context-menu
work. Selection multiple nodes is supported as well.


          ensure that the test runs in all environments

ce56ec3


          add ItemNode.createNonOverlappingSet

5d6d6bc


          add test cases for add ItemNode.createNonOverlappingSet

c77e254


          use ItemNode.createNonOverlappingSet to optimize paths before calling…

0970cd4

… utPLSQL


          use interfaces to enable ModelGoon to draw correct class diagram

71fbc5f


          updated RunnerModel class diagram

4d28aa9

PhilippSalvisberg merged commit 32ef3e1 into main

Jan 3, 2021

PhilippSalvisberg deleted the feature/issue-65-hierarchical-view branch

January 3, 2021 15:15

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alternative hierarchical view

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.