GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bugfix #126 - Suite descriptions are not aggregated by PhilippSalvisberg · Pull Request #130 · utPLSQL/utPLSQL-SQLDeveloper

Conversation

@PhilippSalvisberg

@PhilippSalvisberg PhilippSalvisberg commented Jan 4, 2021

Copy link
Copy Markdown
Member

closes #126 - instead of aggregating suite descriptions the suites without descriptions are left as is.

The root cause of this bug was wrong deserialization of the XML document which used the first description found in a suite, even if it was the description of a child suite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
PhilippSalvisberg added 5 commits January 4, 2021 20:48
@PhilippSalvisberg
expose run in UtplsqlRunner for testing purposes
a1045cb
@PhilippSalvisberg
show test/suite description by default in UtplsqlRunnerTest
4abeec7
@PhilippSalvisberg
add test to reproduce issue #126
ffb8ba5
@PhilippSalvisberg
exclude nested elements in XMLtools.getElementNode
beed2c2 
This ensures that the description of a child suite is not used for a parent suite when the parent suite does not have a description. This was the root cause of issue #126.
@PhilippSalvisberg
show description if it is available, regardless of the node type
51684d7
@PhilippSalvisberg
PhilippSalvisberg merged commit cf26469 into main Jan 4, 2021
@PhilippSalvisberg
PhilippSalvisberg deleted the bugfix/issue-126-suite-descriptions-b branch January 4, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suite descriptions are not aggregated

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@PhilippSalvisberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.