GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bugfix/issue 157 missing line break after suite by PhilippSalvisberg · Pull Request #158 · utPLSQL/utPLSQL-SQLDeveloper

Conversation

@PhilippSalvisberg

@PhilippSalvisberg PhilippSalvisberg commented Jul 23, 2022

Copy link
Copy Markdown
Member
  • fixes Missing line break after suite annotation in generator skeleton template #157 Missing line break after suite annotation in generator skeleton template
  • produces lowercase statement when running utPLSQL in worksheet
  • use JDK17 for tests
  • requires Java17 to build (still produces a JDK8 compatible SQLDev extension)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
PhilippSalvisberg added 12 commits July 23, 2022 15:16
@PhilippSalvisberg
use JDK 17 for tests and produce JDK8 compatible classes, update vers…
72e7b32
…ions of dependencies
@PhilippSalvisberg
fix test with JDK17, throws now a ExceptionInInitializerError
57b8916
@PhilippSalvisberg
second call failed also with JDK17, fix to make test succeed
67462aa
@PhilippSalvisberg
removed Eclipse specific settings in pom.xml
4aa4d4a
@PhilippSalvisberg
configured resources and testResource explicitly in pom.xml
aa14126
@PhilippSalvisberg
use jdk.test.version tag in pom.xml
069be36
@PhilippSalvisberg
add test cases for generator templates
d738d83
@PhilippSalvisberg
unsure generated by comment is enclosed by new lines
230e75a
@PhilippSalvisberg
ensure there is a new line after the package level annotations
1821d2d
@PhilippSalvisberg
change generated statements to lowercase in worksheet runner
291d0e2
@PhilippSalvisberg
update required SQLDev to 21.4.3
87c3c7b
this is the last version that works with JDK8.
To build a JDK 8 compatible extension, this version must be used.
@PhilippSalvisberg
update required maven version
196438f
@PhilippSalvisberg
PhilippSalvisberg merged commit 84e3b9e into main Jul 23, 2022
@PhilippSalvisberg
PhilippSalvisberg deleted the bugfix/issue-157-missing-line-break-after-suite branch July 25, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing line break after suite annotation in generator skeleton template

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@PhilippSalvisberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.