GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't reveal credentials in log and error output by jgebal · Pull Request #232 · utPLSQL/utPLSQL-cli

Conversation

@jgebal

@jgebal jgebal commented Sep 27, 2026

Copy link
Copy Markdown
Member

Closes #172

Summary

The password of the connect string could end up on screen in two ways:

  1. Args debug line. At startup the CLI logs its command line arguments at debug level, connect string included:

    DEBUG org.utplsql.cli.Cli -- Args: run, app/Sup3rSecretPw@//localhost:1521/FREEPDB1
    
  2. Passwords containing @. The connect-string parser ended an unquoted password at the first @. For app/p@ss@host, the password was taken as p and the connect string as ss@host. The connection failed, and part of the password appeared in the connection lines and in the driver's error message, printed on every run:

    jdbc:oracle:thin:****/****@ss@//localhost:1521/FREEPDB1: ORA-12261: ... connection string ss@//localhost:1521/FREEPDB1
    

Behaviour change

Passwords containing @ no longer have to be quoted, thought it's a good ide to keep it that way. Connect strings can not contain @ because everything up to the last @ is taken as the password.
This is fine as connect strings (EZConnect, TNS aliases, descriptors) don't normally contain @.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Jacek Gębal
Resolved issue with credentials leaking into debug log.
0e9158e
Added tests to confirm the solution.
Changed how credentials are parsed to avoid leaking passwords on unquoted passwords with multiple @ signs.
Cleanup, unification and refactoring of credentials masking.

Update of readme to include information about new behavior.
@sonarqubecloud

sonarqubecloud Bot commented Sep 27, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jgebal jgebal mentioned this pull request Sep 27, 2026
Hide password #172
Closed
@jgebal
jgebal merged commit 63f91e1 into develop Sep 27, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@jgebal
jgebal deleted the feature/prevent_logging_credentials branch September 27, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hide password

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.