GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added locale initialization from environment variables LC_ALL or LANG by pesse · Pull Request #59 · utPLSQL/utPLSQL-cli

Conversation

@pesse

@pesse pesse commented Jan 15, 2018

Copy link
Copy Markdown
Member

Fixes #56

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pesse added 3 commits January 15, 2018 11:51
@pesse Samuel Nitsche
Added locale initialization from environment variables LC_ALL or LANG
ba4b5b9 
Fixes #56
@pesse Samuel Nitsche
Update documentation to describe localization
f660875
@pesse Samuel Nitsche
Add NLS_LANG to the list of environment variables which can change th…
2e88a8c 
…e cli locale
jgebal
jgebal reviewed Jan 16, 2018
View reviewed changes

@jgebal jgebal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance to build a test to verify that NLS session parameters are by those environment parameters?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pesse

pesse commented Jan 16, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hm, there is the possibility to check whether java-locale matches with NLS session parameters - but that would be testing JDBC driver, which is IMHO out of scope. All I did was setting java locale depending on environment variables.
A real system-test would be nice where you test running utPLSQL-cli in an environment with specific env variables and check for NLS session parameters then, but atm I don't have an idea how that could be achieved in a useful way.

Edit: I'll have a look at the failsafe-plugin for maven which allows integration tests. Might be what I'm actually looking for...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jgebal
jgebal approved these changes Jan 16, 2018
View reviewed changes
@pesse pesse mentioned this pull request Jan 16, 2018
Investigate failsafe-plugin for maven and create integration-tests #60
Closed
@pesse
pesse merged commit 5a54402 into develop Jan 16, 2018
@pesse
pesse deleted the bugfix/nls_from_environment branch January 16, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pesse @jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.