GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bugfix/class not found jaxb by pesse · Pull Request #86 · utPLSQL/utPLSQL-cli

Conversation

@pesse

@pesse pesse commented May 17, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #82
Fixes #80
Fixes #85

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pesse added 3 commits May 17, 2018 22:15
@pesse
To be honest - that was a pretty dumb way of loading a file...
07b7e75
@pesse
Bump version and fix #82
41367ab
@pesse
Limit connection pool to number of reporters +1
a2a7618 
Fixes #85.
Also added a multi-reporter integration-test
jgebal
jgebal reviewed May 19, 2018
View reviewed changes
Comment thread src/main/java/org/utplsql/cli/RunCommand.java
final ArrayList<String> finalExcludeObjectsList = excludeObjectsList;

final ConnectionInfo ci = getConnectionInfo();
ci.setMaxConnections(getReporterManager().getNumberOfReporters()+1);

@jgebal jgebal May 19, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why +1?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pesse pesse May 19, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we need a separate connection for TestRunner to start. The Reporters are all in their own threads and due to concurrency it's always preferrable to have a separate connection for each thread.
Main thread: TestRunner
Thread 1: Reporter 1
Thread 2: Reporter 2

etc.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jgebal
jgebal approved these changes May 19, 2018
View reviewed changes
@pesse
pesse merged commit e8251c7 into develop May 19, 2018
@pesse
pesse deleted the bugfix/class_not_found_jaxb branch May 19, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pesse @jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.