GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Version info and info command in cli by pesse · Pull Request #87 · utPLSQL/utPLSQL-cli

Conversation

pesse commented May 31, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Fixes #77

Adds a new command "info" with an optional positional parameter to provide a connection.
Will print out information about the version of the used components:

cli 3.1.1-SNAPSHOT.local
Java-API 3.1.1-SNAPSHOT.199
utPLSQL 3.1.2.1913

Not yet done. Still needs heavy refactoring.

Fixes #31

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pesse added 7 commits

May 31, 2018 22:57


          Minimal viable (and ugly) solution to add version info to cli

fbbef6d

Refactoring needed. Tonight is a tough night for concentration. Turning on programming/concentration music didn't help either. Guess what they played? Command&Conquer Soundtrack. Who could concentrate with so many nice and positive memories triggered?


          First set of refactorings around ConnectionInfo

2772add

It should really be only an Info-Object, not a DataSource wannabe


          Refactoring around commands.

457625d

I wanted to have more separation between Main-Class and actual commands. There might still be work left to do, but it's a first throw.


          Improved tests for VersionInfoCommand


          Updated help


          Added another command: reporters <ConnectionUrl>

feff4a3


          Added documentation

52d4368

jgebal reviewed

Jun 8, 2018

View reviewed changes

Comment thread

README.md Outdated


		`utplsql run <ConnectionURL> [-p=(ut_path\|ut_paths)] [-f=format [-o=output_file] [-s] ...]`

		Currently, utPLSQL-cli knows the following commands:

jgebal Jun 8, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supports souds better than knows

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pesse Jun 8, 2018

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

README.md


		#### Enabling Color Outputs on Windows
		### info
		`utplsql info [<ConnectionURL>]`

jgebal Jun 8, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make a separate section for the connection URL and link to it in each command. That way it is defined only once.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pesse Jun 8, 2018

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, came to my mind but wasn't able to come up with a good way and therefore decided to refactor later ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

README.md Outdated

		```
		> utplsql reporters app/app@localhost:1521/ORCLPDB1

		UT_COVERAGE_COBERTURA_REPORTER (SQL): Generates a Cobertura coverage report providing information on code coverage with line numbers.

jgebal Jun 8, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does (SQL) / (SQL_with_Java) mean?
I find it confusing.
Do we need some extra actions for one or another?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pesse Jun 8, 2018

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the concept needs more explanation, still struggling of how to do so.
With 3.1.0 ReporterFactory in cli/java-api you can have

Reporters solely implemented on the database (most core reporters) -> SQL
Reporters solely implemented on the client. You could for example write a Reporter which uses ut_documentation_reporter internally but modifies the output excessively and is registered via a different name (so not overwriting ut_documentation_reporter but just using it internally). -> JAVA
Reporters who are implemented on the database but also have some kind of addition on the client. Best example is the ut_coverage_html_reporter: It's basically the database implemented reporter but has this client-side addition that the assets are written to a specific folder. -> SQL_WITH_JAVA

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jgebal Jun 8, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think users can implement reporters in cli.
We (as dev team) would have to do that.
I would refrain from implementing reporters (based on existing PLSQL reporters) in java.

Can you remove that info?
I'd like to avoid questions/confusinon from users.

If needed, we can add this info to documentation.
The comment seems a good explanation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

README.md Outdated

		```

		### reporters
		`utplsql info <ConnectionURL>`

jgebal Jun 8, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it info or reporters ?
The examples show different command.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pesse Jun 8, 2018

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was definitely too late :) Thanks for finding - it's reporters

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pesse added 3 commits

June 8, 2018 09:56


          Some improvements to documentation

808a2d6


          Refactoring of ReportersCommand

554c71b

Also much nicer formatting


          Some more minor refactoring

93c8e5d

jgebal reviewed

Jun 12, 2018

View reviewed changes

Comment thread

README.md Outdated

		Designed for Jenkins and TFS to report coverage.
		Cobertura Document Type Definition can be found: http://cobertura.sourceforge.net/xml/coverage-04.dtd.
		Sample file: https://github.com/leobalter/testing-examples/blob/master/solutions/3/report/cobertura-coverage.xml.
		UT_COVERAGE_COBERTURA_REPORTER Generates a Cobertura coverage report providing information on code coverage with line numbers.

jgebal Jun 12, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my pedantic hat on - wouldn't it be better to have it formatted with indentation of 4 spaces?

UT_COVERAGE_COBERTURA_REPORTER:
    Generates a Cobertura coverage report providing information on code coverage with line numbers.
    Designed for Jenkins and TFS to report coverage.

Indenting by up to 31 chars seems excessive

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Switch table-like to 4-space intendation

d402718

pesse merged commit 54ad290 into develop

Jun 13, 2018

jgebal deleted the feature/version_info branch

February 7, 2025 09:08

Reviewers

jgebal

jgebal left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

pesse commented May 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pesse commented May 31, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.