GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Commit codestyle to the project and reformat all code by Pazus · Pull Request #76 · utPLSQL/utPLSQL-java-api

Conversation

@Pazus

@Pazus Pazus commented Feb 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Commited codestyle settings:
all default to IDEA except that if, for, while, do force braces for multiline bodies. Meaning you can write either

if (true) bar();

or

if (true) {
  bar();
}

Forcing braces for multiline if/for/etc makes code less error prune. If not forcing one day someone will for sure add second statement and forget to add braces. The code will break and tests may miss it.

All changes in the PR are result of automating IDEA formatting without any handmade changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Pazus
reformat and cleanup all java code with defined codestyle
ff4972c
@Pazus
Pazus requested review from pesse and viniciusam February 22, 2019 19:30
@Pazus
exclude codestyle from gitignore
d8ab01c
added dictionaries to VCS
pesse
pesse approved these changes Mar 4, 2019
View reviewed changes
@pesse
pesse merged commit c4539ea into develop Mar 4, 2019
@Pazus
Pazus deleted the save-codestyle branch March 8, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viniciusam viniciusam Awaiting requested review from viniciusam
1 more reviewer
@pesse pesse pesse approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Pazus @pesse
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.