GeezerVison is showing github.com — Commit codestyle to the project and reformat all code by Pazus · Pull Request #76 · utPLSQL/utPLSQL-java-api
Conversation
Pazus
commented
Feb 22, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Commited codestyle settings:
all default to IDEA except that if, for, while, do force braces for multiline bodies. Meaning you can write either
or
Forcing braces for multiline if/for/etc makes code less error prune. If not forcing one day someone will for sure add second statement and forget to add braces. The code will break and tests may miss it.
All changes in the PR are result of automating IDEA formatting without any handmade changes
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
added dictionaries to VCS
Reviewers
viniciusam
Awaiting requested review from viniciusam
1 more reviewer
pesse
pesse approved these changes
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.