GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bugfix/coverage key value parameter by pesse · Pull Request #90 · utPLSQL/utPLSQL-java-api

Conversation

@pesse

@pesse pesse commented Jul 16, 2019

Copy link
Copy Markdown
Member

When empty TypeMapping parameter is passed, the java-api should assure it is passed to utPLSQL-api as NULL so the default TypeMapping can kick in.

Fixes utPLSQL/utPLSQL-cli#162

Adds some tests, too, and hides TypeMapper from public. Nothing but the java-api should mess with these internals.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pesse added 3 commits July 15, 2019 17:01
@pesse
We don't want to have this publicly accessible
ffc8425
@pesse
Default TypeMapping is used on NULL and also empty typeMap parameter
952d344 
Fixes utPLSQL/utPLSQL-cli#162
@pesse
FileMapper doesn't need to be public
8a326f9
@pesse
pesse requested a review from Pazus July 16, 2019 20:47
pesse added 5 commits July 18, 2019 22:57
@pesse
Simple DynamicParameterList object to make some PL/SQL calls easier
d329e8e
@pesse
Let's do it cleaner and use several DynamicParameter implementations
e6f3a57
@pesse
Add functionality to ignore null or empty adds
c799e6a
@pesse
Fix PL/SQL bug - it's not = but =>
c01e8c2
@pesse
Now let's use that sweet new DynamicParameterListBuilder
9cd9937
Pazus
Pazus suggested changes Jul 19, 2019
View reviewed changes
Comment thread build.gradle.kts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/org/utplsql/api/db/DynamicParameterListBuilder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/org/utplsql/api/db/DynamicParameterList.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/test/java/org/utplsql/api/db/DynamicParameterListTest.java
public class DynamicParameterListTest {

@Test
void call_with_three_different_types() throws SQLException {

@Pazus Pazus Jul 19, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know if you which to create human readable name of a test you can use @Display annotation which will be displayed in the results instead of the method name

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pesse pesse Jul 19, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, the upside of this approach is that I know immediately what the test does without first having to look for the @Display content.
It's a very good addition, though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pesse added 4 commits July 19, 2019 08:31
@pesse
Inlining DynamicParameterListBuilder
db3e1fb
@pesse
Reducing visibilty of some classes and methods, adding comments
e0291ab
@pesse
Add addIfNotEmpty method, remove allowEmpty-flag
d2292cf
@pesse
Use newer mockito framework and have it as testImplementation
1bd0f48
Pazus
Pazus approved these changes Jul 20, 2019
View reviewed changes
@pesse
pesse merged commit 8a4715e into develop Jul 22, 2019
@pesse
pesse deleted the bugfix/coverage_key_value_parameter branch July 22, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Pazus Pazus Pazus approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Coverage files not mapped after upgrade to cli 3.1.7

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pesse @Pazus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.