GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: remove `CARGO_FEATURES_OPTION` by cakebaker · Pull Request #106 · uutils/diffutils

Conversation

@cakebaker

@cakebaker cakebaker commented Nov 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

While looking at the "code coverage" jobs I noticed that CARGO_FEATURES_OPTION is always empty when it's used. This PR adds the missing outputs CARGO_FEATURES_OPTION to ci.yml, though I'm not sure whether CARGO_FEATURES_OPTION is even needed. This PR removes CARGO_FEATURES_OPTION and adds --all-features to where CARGO_FEATURES_OPTION was used.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cakebaker
cakebaker force-pushed the ci_fix_cargo_features_option branch from 9fc79fb to b930211 Compare November 8, 2024 08:39
@codecov

codecov Bot commented Nov 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (3101aa1) to head (90bed40).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   84.97%   84.97%           
=======================================
  Files          12       12           
  Lines        5829     5829           
  Branches      475      475           
=======================================
  Hits         4953     4953           
  Misses        861      861           
  Partials       15       15
Flag Coverage Δ
macos_latest 84.93% <ø> (ø)
ubuntu_latest 85.17% <ø> (ø)
windows_latest 22.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cakebaker
ci: remove CARGO_FEATURES_OPTION
90bed40
@cakebaker
cakebaker force-pushed the ci_fix_cargo_features_option branch from b930211 to 90bed40 Compare November 8, 2024 08:48
@cakebaker cakebaker changed the title ci: add missing outputs CARGO_FEATURES_OPTION ci: remove CARGO_FEATURES_OPTION Nov 8, 2024
oSoMoN
oSoMoN approved these changes Nov 8, 2024
View reviewed changes

@oSoMoN oSoMoN left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not making use of features anyway.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oSoMoN
oSoMoN merged commit dcd3dfd into uutils:main Nov 8, 2024
@cakebaker
cakebaker deleted the ci_fix_cargo_features_option branch November 8, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oSoMoN oSoMoN oSoMoN approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cakebaker @oSoMoN
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.