GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Run the upstream test suite in CI (fixes #8) by oSoMoN · Pull Request #13 · uutils/diffutils

Conversation

@oSoMoN

@oSoMoN oSoMoN commented Feb 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The script takes a shortcut to fetch only the test suite from the upstream repository and carefully avoids running the autotools machinery which is time-consuming and resource-intensive, and doesn't offer the option to not build the upstream binaries.
As a consequence, the environment in which the tests are run might not match exactly that used when the upstream tests are run through the autotools. Whether tests are failing because of an incorrect environment remains to be investigated.

Unsurprisingly a number of tests are failing because of missing options in the current implementation or discrepancy in the output. These will need to be implemented/fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
oSoMoN added 6 commits February 10, 2024 00:42
@oSoMoN
Naive script that runs relevant upstream tests against our diffutils …
15ba584
…binary
@oSoMoN
Also report skipped tests
37ae1c8
@oSoMoN
Pass the build profile as parameter
95b8e5d
@oSoMoN
Run the upstream test suite in CI
ddb3169
@oSoMoN
Set $TERM to please tput
2739956
@oSoMoN
More explicit comments
6fee076
@sylvestre

sylvestre commented Feb 11, 2024

Copy link
Copy Markdown
Collaborator

The job should not fail.
And we should generate a json at the end like the coreutils but it can be done in another pr.

Please let me know when it is ready for review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN
Do not fail when run in CI, the report is merely informative (at leas…
143359d
…t until all tests pass reliably)
@oSoMoN

oSoMoN commented Feb 11, 2024

Copy link
Copy Markdown
Collaborator Author

The job should not fail. And we should generate a json at the end like the coreutils but it can be done in another pr.

I tweaked the workflow to not fail when run in CI. I'll look into generating that JSON data as soon as I get a chance.

Please let me know when it is ready for review

Almost there, I would like to allow run-upstream-testsuite.sh to run selected tests only, and to report results more verbosely to ease investigation of failures. I'm converting this PR to draft until it's ready for review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN
oSoMoN marked this pull request as draft February 11, 2024 21:38
@oSoMoN
Allow running a subset of tests by setting the TESTS environment vari…
149c044
…able
@sylvestre

sylvestre commented Feb 12, 2024

Copy link
Copy Markdown
Collaborator

Do you think it would be possible to show the errors in the log ? thanks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN
Export detailed test results to a JSON file and expose it as an artif…
76dce3d
…act for CI runs
@oSoMoN
oSoMoN force-pushed the run-upstream-testsuite branch from 74fa543 to 76dce3d Compare February 12, 2024 22:37
oSoMoN added 3 commits February 13, 2024 19:39
@oSoMoN
Log stdout and stderr for each test run
faa810f
@oSoMoN
Add a comment to justify not including the contents of subdirectories
55bc85d
@oSoMoN
Add relevant metadata to the JSON output
fed876b
@oSoMoN
oSoMoN force-pushed the run-upstream-testsuite branch from 8d89a9e to fed876b Compare February 13, 2024 20:54
oSoMoN added 3 commits February 15, 2024 20:44
@oSoMoN
Include a URL to the test script on the upstream cgit webUI
553ac75
@oSoMoN
Add a script to print the test results
a526208
@oSoMoN
Move helper scripts for running the upstream test suite in a tests/ s…
3a83bbf
…ubdirectory
@oSoMoN
oSoMoN force-pushed the run-upstream-testsuite branch from 0fb0544 to 3a83bbf Compare February 15, 2024 20:10
oSoMoN added 3 commits February 15, 2024 21:51
@oSoMoN
Print a summary after running all tests
63388ad
@oSoMoN
Simplify codeblock function
5ccb762
@oSoMoN
Document the test scripts, and cosmetic changes
90d9826
@oSoMoN
oSoMoN marked this pull request as ready for review February 16, 2024 21:25
@oSoMoN

oSoMoN commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator Author

I believe this is now ready for review.

Do you think it would be possible to show the errors in the log ? thanks

I added a script that prints out details about every test (including the contents of stdout and stderr) in a markdown format, convenient for filing issues to track tests with an unexpected result. When rendered it looks like this:

test: excess-slash

result: FAIL
url: https://git.savannah.gnu.org/cgit/diffutils.git/tree/tests/excess-slash?id=6c88db1f7bfc25b1480d9876dac25024aa688544

stdout

diff -u /dev/null err
--- /dev/null	1970-01-01
+++ err	1970-01-01
+Error: "Unknown option: r"
--- expected-out	
+++ out	
@@ -1 +0,0 @@
-Only in b/f: g
Not removing temporary directory /tmp/tmp.3jNgxNWI94/diffutils/tests/gt-excess-slash.YClC
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sylvestre
sylvestre reviewed Feb 17, 2024
View reviewed changes
Comment thread .github/workflows/ci.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sylvestre
Rename the task
3f86d9c
@sylvestre
sylvestre merged commit 790ef1e into uutils:main Feb 17, 2024
@sylvestre

sylvestre commented Feb 17, 2024

Copy link
Copy Markdown
Collaborator

excellent, thanks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN
oSoMoN deleted the run-upstream-testsuite branch February 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@oSoMoN @sylvestre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.