GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix compilation for 32-bit targets by LunarEclipse363 · Pull Request #146 · uutils/diffutils

Conversation

@LunarEclipse363

@LunarEclipse363 LunarEclipse363 commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

This change makes the code compile for 32-bit targets (in my case armv7-unknown-linux-musleabihf, targeting a 2012 kindle non-touch e-book reader).

The failure without it is that some of the string literals exceed the size limit of a u32.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@LunarEclipse363
Fix compilation for 32-bit targets
ced30b0
@codecov

codecov Bot commented Nov 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.25%. Comparing base (83f6d2d) to head (ced30b0).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/cmp.rs 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   86.30%   86.25%   -0.05%     
==========================================
  Files          13       13              
  Lines        6227     6206      -21     
  Branches      511      514       +3     
==========================================
- Hits         5374     5353      -21     
  Misses        852      852              
  Partials        1        1
Flag Coverage Δ
macos_latest 86.20% <88.88%> (-0.05%) ⬇️
ubuntu_latest 86.32% <88.88%> (-0.05%) ⬇️
windows_latest 19.89% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kov
kov reviewed Dec 21, 2025
View reviewed changes

@kov kov left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I wonder if there is a way to teach codecov about unreachable!()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oSoMoN
oSoMoN merged commit a09dcac into uutils:main Dec 21, 2025
27 of 28 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kov kov kov left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@LunarEclipse363 @kov @oSoMoN
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.