GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — cmp_fast_path test improvements by kov · Pull Request #152 · uutils/diffutils

Conversation

@kov

@kov kov commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

I've had a couple issues with this test on my Mac, which this PR fixes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kov added 2 commits December 26, 2025 14:52
@kov
Use specific locale for cmp_fast_path test
8997ac0 
The test was failing in the regular MacOS terminal due to it defaulting
to LC_ALL=C. Best to standardize like the other tests that check for
locale-dependent output.
@kov
Make cmp_fast_path more robust
7ddc6c6 
On my Mac I see this test fail quite consistently. This change makes it
more resilient in systems with slower startup times, while still
allowing faster systems to finish as soon as possible.
@codecov

codecov Bot commented Dec 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.34%. Comparing base (df90e37) to head (7ddc6c6).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
tests/integration.rs 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   86.35%   86.34%   -0.02%     
==========================================
  Files          13       13              
  Lines        6207     6217      +10     
  Branches      520      521       +1     
==========================================
+ Hits         5360     5368       +8     
- Misses        846      848       +2     
  Partials        1        1
Flag Coverage Δ
macos_latest 86.29% <83.33%> (-0.02%) ⬇️
ubuntu_latest 86.38% <83.33%> (-0.02%) ⬇️
windows_latest 20.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kov

kov commented Dec 26, 2025

Copy link
Copy Markdown
Contributor Author

I don't think it makes sense to address the codecov complaint as those codepaths are in the test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sylvestre
sylvestre merged commit f66ad85 into uutils:main Jan 1, 2026
26 of 28 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kov @sylvestre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.