GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: match GNU error format for unrecognized options by Ryujiyasu · Pull Request #180 · uutils/diffutils

Conversation

@Ryujiyasu

@Ryujiyasu Ryujiyasu commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #178 / #179. Adjusts the unrecognized option error message to match the actual GNU diff/cmp output format:

  • Remove colon after unrecognized option
  • Use single quotes instead of double quotes ('--foobar' instead of "--foobar")
  • Use contains instead of starts_with in integration test to handle the command prefix (e.g. cmp: unrecognized option ...)

Before: unrecognized option: "--foobar"
After: unrecognized option '--foobar'

As pointed out by @GunterSchmidt in #178 (comment).

Test plan

  • cargo test — all 125 unit tests and 21 integration tests pass
  • Verified diffutils diff --foobar outputs unrecognized option '--foobar'
  • Verified diffutils cmp --foobar outputs unrecognized option '--foobar'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
GunterSchmidt
GunterSchmidt approved these changes Feb 28, 2026
View reviewed changes

@GunterSchmidt GunterSchmidt left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ryujiyasu reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@GunterSchmidt GunterSchmidt mentioned this pull request Mar 1, 2026
cmp -> unknown -> unrecognized, follow up to issue #178 #181
Closed
Ryujiyasu and others added 2 commits March 7, 2026 18:35
@Ryujiyasu @claude @sylvestre
fix: match GNU error format for unrecognized options
5becc7d 
Use single quotes and remove colon to match GNU diff/cmp output:
`unrecognized option '--foobar'` instead of `unrecognized option: "--foobar"`

Also use `contains` instead of `starts_with` in the integration test
to handle the command prefix (e.g. `cmp: unrecognized option ...`).

Follow-up to uutils#178 / uutils#179.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@Ryujiyasu @claude @sylvestre
style: apply cargo fmt formatting
5398c6d 
Co-Authored-By: Claude Opus 4.6 <[email protected]>
@sylvestre
sylvestre force-pushed the fix/unrecognized-option-format branch from e6a28ea to 5398c6d Compare March 7, 2026 17:35
@codspeed

codspeed Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 26 untouched benchmarks

Comparing Ryujiyasu:fix/unrecognized-option-format (5398c6d) with main (59e130a)

Open in CodSpeed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oSoMoN

oSoMoN commented Mar 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The change looks harmless. I haven't been paying much attention to uutils/diffutils lately, and I'm having a hard time parsing the following things:

  • The two commits in this PR are co-authored by Claude Opus 4.6, but their contents are really very trivial. Is that a reasonable use of LLMs? Has the use of coding agents been discussed in the context of uutils, do we have some sort of policy/guidelines around their usage in the projects?
  • The two commits are authored by @Ryujiyasu, but committed by @sylvestre, in Ryuji Yasukochi's branch. What's up with this? EDIT: is this because Sylvestre rebased and force-pushed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sylvestre
sylvestre merged commit 9dcca24 into uutils:main Mar 10, 2026
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (59e130a) to head (5398c6d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #180   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BrewTestBot BrewTestBot mentioned this pull request Oct 23, 2026
uutils-diffutils 0.6.0 Homebrew/homebrew-core#320660
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@GunterSchmidt GunterSchmidt GunterSchmidt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Ryujiyasu @oSoMoN @GunterSchmidt @sylvestre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.