GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Divan Benchmark by GunterSchmidt · Pull Request #185 · uutils/diffutils

Conversation

@GunterSchmidt

@GunterSchmidt GunterSchmidt commented Mar 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

During development it is often helpful to be able to quickly benchmark the recent changes.

Criterion offers the ability to bench single functions.

This PR introduces criterion and has benches for the parsers (negligible) and cmp compare.

Has also a support function to generate large files to compare for bench-marking.

Update: Changed to Codspeed with Divan.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Gunter Schmidt
feat: Criterion Benchmark
db4aa4d
@GunterSchmidt GunterSchmidt mentioned this pull request Mar 2, 2026
Divan Benchmark for Development #186
Closed
@sylvestre

sylvestre commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

we, uutils, use codspeed

ex: uutils/coreutils#10996

could you please copy what is done with coreutils ?
thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oech3

oech3 commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

CodSpeed does not count some syscalls. How about your suggestion?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Gunter Schmidt
fix: Replaced Criterion with codspeed drop-in replacement
6d01c76
@GunterSchmidt

GunterSchmidt commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre : I am not sure what you mean by "copy". Could you please elaborate.

I just migrated to codspeed criterion drop-in replacement. But would you like me to drop Criterion and use the divan benchmark instead? At this early stage this would not be too hard.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sylvestre

sylvestre commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

yes, please use divan
and i will connect codspeed to this repo
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Gunter Schmidt
feat: uses Divan instead of Criterion
fe9b622
@GunterSchmidt

GunterSchmidt commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

I removed Criterion and migrated the tests to Divan.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GunterSchmidt GunterSchmidt changed the title feat: Criterion Benchmark feat: Divan Benchmark Mar 4, 2026
Gunter Schmidt
changed file num lines to file size in kb
725b89f
@GunterSchmidt

GunterSchmidt commented Mar 7, 2026

Copy link
Copy Markdown
Contributor Author

I found the performance.md for coreutils and will rework this now to match that logic.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sylvestre
sylvestre merged commit 54c8b7a into uutils:main Mar 7, 2026
26 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Mar 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6f082c6) to head (725b89f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #185   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sylvestre
sylvestre reviewed Mar 7, 2026
View reviewed changes
Comment thread benches/bench-diffutils.rs
bencher
// .with_inputs(|| prepare::cmp_params_identical_testfiles(lines))
.with_inputs(|| params.clone())
.bench_refs(|params| black_box(cmp::cmp(&params).unwrap()));

@sylvestre sylvestre Mar 7, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i approved it too quickly. you should not call it as blackbox

the stack isn't currently interesting:

Image

it should call the rust function directly

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@GunterSchmidt GunterSchmidt Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will remove blackbox

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@BrewTestBot BrewTestBot mentioned this pull request Oct 23, 2026
uutils-diffutils 0.6.0 Homebrew/homebrew-core#320660
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@GunterSchmidt @sylvestre @oech3
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.