GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Feat: Added Spell-Checker and fixed spellings by GunterSchmidt · Pull Request #208 · uutils/diffutils

Conversation

GunterSchmidt commented Apr 11, 2026

Copy link

Copy Markdown

Contributor

For Code Spell Checker extension.

Fixed some clippy warnings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

GunterSchmidt mentioned this pull request

Apr 11, 2026

Breaking: Adapt coreutils dev file structure V2 #206

Closed


          Feat: Added Spell-Checker and fixed spellings

For Code Spell Checker extension.

Fixed some clippy warnings.

GunterSchmidt force-pushed the add_cspell_project_dictionaries branch from af533ab to 2646457 Compare

April 12, 2026 21:24

GunterSchmidt commented Apr 15, 2026

Copy link

Copy Markdown

Contributor Author

@sylvestre Could you take a look at this? I then can continue

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marc-hb reviewed

May 7, 2026

View reviewed changes

marc-hb left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes require a very different level of review attention. So when you have clippy fixes sneaking in with much larger spell check changes, now all changes require a high-level of review attention and workload - cause you can't be sure.

The commit message and title should mention that the spell checker configuration are only usable by VSCode (and not run in CI either).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sylvestre reviewed

May 14, 2026

View reviewed changes

Comment thread

benches/bench-diffutils.rs

		//! File generation up to 1 GB is really fast, Benchmarking above 100 MB takes very long.

		// clippy analyzes wrongly
		#![allow(dead_code)]

sylvestre May 14, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please share more details?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

GunterSchmidt May 24, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylvestre Yes, I get unused code warnings for constants and functions used in the benches. This only happens when I run "cargo clippy --workspace --all-targets --all-features" and may have to do with the benches not being used in normal coding. I have no idea how to prevent this from happening.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sylvestre May 24, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems unrelated to the spell changes
please do that in a different pr

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

GunterSchmidt and others added 3 commits

May 24, 2026 15:10


          Merge branch 'uutils:main' into add_cspell_project_dictionaries

1c0efe8


          [pre-commit.ci] auto fixes from pre-commit.com hooks

99e8cb8

for more information, see https://pre-commit.ci


          added diffutilslib to wordlist, commented on clippy issue

541e733

GunterSchmidt commented May 24, 2026

Copy link

Copy Markdown

Contributor Author

@marc-hb I have no clue what you are trying to say. There are no code changes in here, so what can you not be sure? And for the spell-checker, yes, it is a VS Code extension, but I do not know if the same provider offers extensions for other IDEs which work identical.

This is the same as in coreutils, therefore I did not explain the reasoning behind it.

Please clarify your issue and give an example where it makes code review more complex.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sylvestre reviewed

May 24, 2026

View reviewed changes

Comment thread

benches/bench-diffutils.rs


		/// Generate test files with these sizes in KB.
		const FILE_SIZE_KILO_BYTES: [u64; 4] = [100, 1 * MB, 10 * MB, 25 * MB];
		const FILE_SIZE_KILO_BYTES: [u64; 4] = [100, MB, 10 * MB, 25 * MB];

sylvestre May 24, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, should be in a different pr

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

GunterSchmidt May 24, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I sometimes have to do these changes as clippy complains. As this is not any actual change, I did not create a separate PR. But if that is easier for the reviewers, I will do better. This are then more PRs which I thought would be more work.

So I will remove the benches changes from this PR and create a separate one. No prob.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

marc-hb May 25, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the best guides on this topic in my subjective opinion:

https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#defining-smaller-prs

It has been written by maintainers of a very active project.

A middle-ground is to split into separate commits inside the same PR instead of submitting separate PRs, as also described there. However, this means git commits cannot be used for addressing review comments anymore (no "fixup" commits). https://blog.buenzli.dev/announcing-development-on-flirt#the-pr-workflow So it's probably not compatible with this project

This page is also pretty good: https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

marc-hb commented May 24, 2026

Copy link

Copy Markdown

Contributor

Just try to put yourself in the shoes of an overworked maintainer trying to review a bag of different things unrelated to each other but mixed together.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sylvestre requested changes

Jun 3, 2026

View reviewed changes

sylvestre left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be split

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sylvestre reviewed

Oct 18, 2026

View reviewed changes

Comment thread

.vscode/cSpell.json

		"oranda.json",
		"target/**",
		"tests//fixtures/",
		"src/uu/dd/test-resources/**",

sylvestre Oct 18, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of these paths don't exist in diffutils (src/uu/dd, gnu-patches, release-notes, check-safe-traversal.sh...)
could you please only keep what is relevant here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sylvestre reviewed

Oct 18, 2026

View reviewed changes

Comment thread

.vscode/cspell.dictionaries/acronyms+names.wordlist.txt

		EditorConfig
		EPEL
		FreeBSD
		genric

sylvestre Oct 18, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a typo, it should not be whitelisted

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sylvestre reviewed

Oct 18, 2026

View reviewed changes

Comment thread

.vscode/cspell.dictionaries/jargon.wordlist.txt

		SETFL
		tmpfs

		Hijri

sylvestre Oct 18, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, Hijri/Nowruz have nothing to do with diffutils :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sylvestre reviewed

Oct 18, 2026

View reviewed changes

Comment thread

.vscode/cspell.dictionaries/workspace.wordlist.txt

		debuginfo
		tabsize

		# * the following part is a copy of coreutils *

sylvestre Oct 18, 2026

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need the whole coreutils list? stty flags, errno, utmpx, french translation words...
please keep only the words diffutils actually uses

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Merge branch 'main' into add_cspell_project_dictionaries

c8fd560

sylvestre commented Oct 23, 2026

Copy link

Copy Markdown

Collaborator

thanks for this PR!
Still waiting on the earlier comments: the wordlists and ignorePaths are still the coreutils copy, and the bench changes need to go into their own PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

sylvestre

sylvestre requested changes

+1 more reviewer

marc-hb

marc-hb left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

GunterSchmidt commented Apr 11, 2026

Uh oh!

GunterSchmidt commented Apr 15, 2026

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GunterSchmidt commented May 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marc-hb May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marc-hb commented May 24, 2026

Uh oh!

sylvestre left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sylvestre commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marc-hb May 25, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.