GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — cmp: use .map_err by oech3 · Pull Request #236 · uutils/diffutils

Conversation

@oech3

@oech3 oech3 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oech3
oech3 marked this pull request as ready for review June 3, 2026 12:24
@codspeed

codspeed Bot commented Jun 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 5.46%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 25 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation cmp_parser 5.6 µs 5.9 µs -5.46%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing oech3:cmp-map_err (5740d85) with main (f29e96c)

Open in CodSpeed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oech3
oech3 force-pushed the cmp-map_err branch from 1c7e88e to 7c23ada Compare June 3, 2026 12:25
@github-actions

github-actions Bot commented Jun 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

GNU diffutils testsuite comparison:

Test results comparison:
  Current:   TOTAL: 33 / PASSED: 0 / FAILED: 33 / SKIPPED: 0
  Reference: TOTAL: 33 / PASSED: 8 / FAILED: 21 / SKIPPED: 4

Changes from main branch:
  TOTAL: +0
  PASSED: -8
  FAILED: +12

New test failures (12):
  - basic
  - bignum
  - brief-vs-stat-zero-kernel-lies
  - bug-64316
  - cmp
  - diff3
  - help-version
  - large-subopt
  - strcoll-0-names
  - strip-trailing-cr
  - timezone
  - y2038-vs-32bit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marc-hb

This comment was marked as low quality.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oech3

This comment was marked as resolved.

Sign in to view
@marc-hb

marc-hb commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Need more coffee? Sincere apologies for the noise.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oech3

oech3 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

No problem. Thankyou for reviewing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oech3
oech3 marked this pull request as draft June 4, 2026 14:48
@oech3 oech3 closed this Jun 8, 2026
@oech3
oech3 deleted the cmp-map_err branch June 8, 2026 15:42
@oech3

This comment was marked as low quality.

Sign in to view
@oech3
oech3 restored the cmp-map_err branch June 9, 2026 17:33
@oech3 oech3 reopened this Jun 9, 2026
@oech3
oech3 force-pushed the cmp-map_err branch from 7c23ada to ccbbc5e Compare June 9, 2026 17:33
@oech3
oech3 marked this pull request as ready for review June 9, 2026 17:35
@oech3
oech3 force-pushed the cmp-map_err branch from ccbbc5e to c58eb32 Compare June 10, 2026 06:02
oech3 @oech3
cmp: use .map_err
5740d85
@oech3
oech3 force-pushed the cmp-map_err branch from c58eb32 to 5740d85 Compare June 10, 2026 08:24
@cakebaker
cakebaker merged commit dc9ca17 into uutils:main Jun 10, 2026
29 of 31 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@cakebaker

cakebaker commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oech3
oech3 deleted the cmp-map_err branch June 10, 2026 13:13
@BrewTestBot BrewTestBot mentioned this pull request Oct 23, 2026
uutils-diffutils 0.6.0 Homebrew/homebrew-core#320660
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@marc-hb marc-hb marc-hb left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@oech3 @marc-hb @cakebaker
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.