GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — cmp: use checked subtraction for the verbose offset padding by MsfPablo · Pull Request #275 · uutils/diffutils ConversationFixes #265. The $ printf '\377%.0s' {1..150} > nz $ cmp --verbose /dev/zero nz Before, that stops after byte 99 (abort under overflow-checks, a huge padding loop otherwise). After, all 150 lines print and it exits 1. Made the two branches match rather than adding a separate guard. Worth flagging since the issue shows GNU's output: the column is still narrower than GNU's here, because Tests: an integration test covering the case, gated to unix for
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe --verbose branch of format_verbose_difference padded the byte-offset column with a plain subtraction while the --print-bytes branch above it already used saturating_sub. offset_width is derived from the smaller file's metadata length, so a file reporting length 0 that still yields bytes (/dev/zero) collapses it to 2 and the subtraction underflows once the offset reaches three digits. Fixes uutils#265
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. cmp:--verbose on a zero-length-metadata file underflows the offset padding (overflow-checks only)
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |