GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — diff: keep an exact-name dangling symlink with --ignore-file-name-case by binhvq · Pull Request #377 · uutils/diffutils

Conversation

@binhvq

@binhvq binhvq commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #357.

directory_entry used Path::exists(), which follows symlinks, so a dangling symlink with the exact name counted as missing and a case variant was compared instead. Use symlink_metadata().

The bug only shows when the directory lists the case variant before the link (tmpfs lists newest first, btrfs oldest first), so the test builds both layouts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
binhvq added 5 commits November 11, 2026 14:44
@binhvq
diff: keep an exact-name dangling symlink with --ignore-file-name-case
1550b74 
For 'diff FILE DIR' the entry of DIR was looked up with Path::exists(), which follows symlinks. A dangling symlink named exactly like FILE counted as missing, and a differently cased entry was compared instead when the directory listed it first.
@binhvq
test: skip dangling link case on case-insensitive file systems
ea1a87b
@binhvq
Merge remote-tracking branch 'origin/main' into ignore-case-exact-dan…
50ffa55 
…gling-link

# Conflicts:
#	tests/by-util/test_diff.rs
@binhvq
Merge remote-tracking branch 'origin/main' into ignore-case-exact-dan…
cb7645c 
…gling-link
@binhvq
tests: port the dangling link case test to uutests
96f1ecc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

diff - --ignore-file-name-case picks a case variant over an exact-name dangling symlink

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@binhvq
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.