GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP: windows port by calixteman · Pull Request #42 · uutils/diffutils

Conversation

@calixteman

@calixteman calixteman commented Apr 2, 2024

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@calixteman
WIP
eb25268
@sylvestre sylvestre changed the title WIP WIP: windows port Apr 2, 2024
@sylvestre

sylvestre commented Apr 2, 2024

Copy link
Copy Markdown
Collaborator

@oSoMoN Would you be able to finish this PR ? :) thanks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN

oSoMoN commented Apr 2, 2024

Copy link
Copy Markdown
Collaborator

My experience with Windows is rusty (pun intended) at best, and I have no Windows machine handy, but I can take a look when time permits.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN

oSoMoN commented Apr 4, 2024

Copy link
Copy Markdown
Collaborator

@calixteman instead of a custom, platform-specific split_at_eol macro, why not use str::lines() from the standard library?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN oSoMoN mentioned this pull request Apr 20, 2024
Windows tests are failing #3
Closed
@oSoMoN

oSoMoN commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator

Per #3 (comment), I'm closing this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN oSoMoN closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@calixteman @sylvestre @oSoMoN
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.