GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Handle long option names for the supported output styles… by oSoMoN · Pull Request #52 · uutils/diffutils

Conversation

@oSoMoN

@oSoMoN oSoMoN commented Apr 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

… as well as all valid combinations accepted by GNU diff to request a context/unified diff.

I initially intended to use a ready-made library (like clap) to parse parameters in an easier to read/maintain fashion, but I had to give up on the idea for the sake of compatibility with GNU diff's implementation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sylvestre
sylvestre reviewed Apr 9, 2024
View reviewed changes
Comment thread src/params.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Apr 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.20%. Comparing base (3a8eddf) to head (b7261a4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   80.03%   81.20%   +1.16%     
==========================================
  Files          10       10              
  Lines        2730     2894     +164     
  Branches      680      737      +57     
==========================================
+ Hits         2185     2350     +165     
+ Misses        524      523       -1     
  Partials       21       21
Flag Coverage Δ
macos_latest 82.08% <100.00%> (+1.14%) ⬆️
ubuntu_latest 74.79% <71.56%> (-0.15%) ⬇️
windows_latest 15.20% <19.90%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oSoMoN oSoMoN mentioned this pull request Apr 13, 2024
Uploading reports to codecov.io fails #53
Closed
@oSoMoN
oSoMoN force-pushed the long-options branch from b448885 to d9be385 Compare April 16, 2024 16:23
@sylvestre
sylvestre force-pushed the long-options branch from d9be385 to 01fb028 Compare April 16, 2024 19:36
@oSoMoN
oSoMoN force-pushed the long-options branch 2 times, most recently from 0f40bd8 to 77309e5 Compare April 17, 2024 17:26
@sylvestre
sylvestre force-pushed the long-options branch from 77309e5 to 672a4ad Compare April 21, 2024 07:38
oSoMoN added 4 commits April 22, 2024 18:01
@oSoMoN
Parse all valid arguments accepted by GNU diff to request a unified c…
fe28610 
…ontext (with an optional number of lines)
@oSoMoN
Parse all valid arguments accepted by GNU diff to request a regular c…
22d973f 
…ontext (with an optional number of lines)
@oSoMoN
Handle --normal, -e and --ed options
37fe1ae
@oSoMoN
Break out the logic to match context/unified diff params into separat…
b7261a4 
…e functions, for improved readability
@oSoMoN
oSoMoN force-pushed the long-options branch from 672a4ad to b7261a4 Compare April 22, 2024 16:20
@sylvestre

sylvestre commented Apr 23, 2024

Copy link
Copy Markdown
Collaborator

nice:
codecov/project — 81.20% (+1.16%) compared to 3a8eddf
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sylvestre
sylvestre merged commit 8de0ca6 into uutils:main Apr 23, 2024
@oSoMoN
oSoMoN deleted the long-options branch April 30, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@oSoMoN @sylvestre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.