GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use the instrumentation-based code coverage implementation by oSoMoN · Pull Request #70 · uutils/diffutils

Conversation

@oSoMoN

@oSoMoN oSoMoN commented Apr 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This requires more work to figure out why the generated reports are unusable.

EDIT: fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@oSoMoN
oSoMoN marked this pull request as draft April 30, 2024 22:11
@oSoMoN
oSoMoN force-pushed the grcov-instrumentation-based-coverage branch from d2ae264 to 02aee3d Compare August 10, 2024 10:50
@codecov

codecov Bot commented Aug 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (b815162) to head (dbabf39).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   82.01%   81.12%   -0.89%     
==========================================
  Files          10       10              
  Lines        3013     4227    +1214     
  Branches      753      403     -350     
==========================================
+ Hits         2471     3429     +958     
- Misses        513      778     +265     
+ Partials       29       20       -9     
Flag Coverage Δ
macos_latest 81.23% <ø> (-1.63%) ⬇️
ubuntu_latest 81.42% <ø> (+5.69%) ⬆️
windows_latest 20.41% <ø> (+4.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN
oSoMoN force-pushed the grcov-instrumentation-based-coverage branch from 02aee3d to 3d8ba75 Compare August 10, 2024 11:14
@oSoMoN

oSoMoN commented Aug 10, 2024

Copy link
Copy Markdown
Collaborator Author

Generated reports are now correct and usable on unix and macos, but running cargo test with -Cinstrument-coverage on windows now fail:

process didn't exit successfully: `D:\a\diffutils\diffutils\target\debug\deps\diffutilslib-a04822fa61f6982e.exe` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

This requires further investigation, but the results on unix/macos are already quite promising.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN

oSoMoN commented Aug 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

Removing -Clink-dead-code from $RUSTFLAGS results in the tests passing on Windows.

This looks very similar to rust-lang/rust#76038. An old comment on that issue claims that:

-Clink-dead-code is no longer required or recommended when enabling coverage instrumentation

So let's just go with it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN
oSoMoN marked this pull request as ready for review August 15, 2024 22:31
@oSoMoN oSoMoN changed the title [WIP] Use the instrumentation-based code coverage implementation Use the instrumentation-based code coverage implementation Aug 15, 2024
@oSoMoN
Use the instrumentation-based code coverage implementation
dbabf39
@oSoMoN
oSoMoN force-pushed the grcov-instrumentation-based-coverage branch from 3ca9ca6 to dbabf39 Compare August 15, 2024 22:36
@sylvestre
sylvestre merged commit 6ec8370 into uutils:main Sep 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 12, 2024
uutils-diffutils 0.4.2 Homebrew/homebrew-core#188023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@oSoMoN @sylvestre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.