GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Rename the `diffutils` binary to `diff`, by oSoMoN · Pull Request #75 · uutils/diffutils

Conversation

@oSoMoN

@oSoMoN oSoMoN commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

in preparation for the future implementation of other binaries (cmp, sdiff and diff3)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@oSoMoN
Rename the diffutils binary to diff,
9a7d8c8
in preparation for the future implementation of other binaries (cmp, sdiff and diff3)
@codecov

codecov Bot commented Jun 4, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.06%. Comparing base (d362046) to head (9a7d8c8).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
tests/integration.rs 0.00% 0 Missing and 16 partials ⚠️

❗ There is a different number of reports uploaded between BASE (d362046) and HEAD (9a7d8c8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (d362046) HEAD (9a7d8c8)
ubuntu_latest 2 1
macos_latest 2 0
windows_latest 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   82.48%   75.06%   -7.42%     
==========================================
  Files          10       10              
  Lines        2935     2876      -59     
  Branches      744      744              
==========================================
- Hits         2421     2159     -262     
  Misses        495      495              
- Partials       19      222     +203     
Flag Coverage Δ
macos_latest ?
ubuntu_latest 75.45% <0.00%> (ø)
windows_latest 15.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sylvestre

sylvestre commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

what is your plan here? Create new binaries ?

What about doing the same as coreutils ? One main binaries (or individual programs)
and if you do ln -s diffutils diff or ln -s diffutils cmp, it will change the behavior of the command.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN

oSoMoN commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator Author

I was thinking of individual binaries, but I must admit I didn't look at how it's done for coreutils, and I suppose it makes sense to do something similar. I'll take a look later, in the meantime I'm leaving this PR open.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN
oSoMoN marked this pull request as draft June 4, 2024 18:28
@sylvestre

sylvestre commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

the main adv is the size of the binaries as Rust bins have a tendency to be bigger than C :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN

oSoMoN commented Sep 26, 2024

Copy link
Copy Markdown
Collaborator Author

Closing, as this is definitely being obsoleted by Gustavo's work in #88.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oSoMoN oSoMoN closed this Sep 26, 2024
@oSoMoN
oSoMoN deleted the several-binaries branch September 26, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@oSoMoN @sylvestre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.