GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add highlight group for parentheses by tyok · Pull Request #396 · vim-ruby/vim-ruby

Conversation

@tyok

@tyok tyok commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

Hi,

I tried adding a highlight group for parentheses and so far it's been working.

I have to remove a line because methods with only keyword arguments didn't behave properly:

User.where("name = :name", name: "John") # The parens gets highlighted as expected
User.new(name: "John")  # The parens didn't get highlighted
User.new( name: "John") # Strangely, this works fine

I tried to find out if the removed line will break anything, but nothing so far. I think it was supposed to prevent highlighting some symbol name as keyword (0e58499), but I have checked that it's still working without that line. I probably should mention that I don't understand what the regex means.

Please tell me if there's a better way. Thanks for your time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tyok
Add highlight group for parentheses
4ea9c77
@dkearns dkearns added the syntax label Apr 4, 2019
@tyok
Symbol stuff
7803294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

syntax

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tyok @dkearns
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.